From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12421 invoked from network); 26 Jun 2009 22:19:37 -0000 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.5 Received: from new-brage.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.254.104) by ns1.primenet.com.au with SMTP; 26 Jun 2009 22:19:37 -0000 Received-SPF: none (ns1.primenet.com.au: domain at sunsite.dk does not designate permitted sender hosts) Received: (qmail 67792 invoked from network); 26 Jun 2009 22:19:31 -0000 Received: from sunsite.dk (130.225.247.90) by a.mx.sunsite.dk with SMTP; 26 Jun 2009 22:19:31 -0000 Received: (qmail 28159 invoked by alias); 26 Jun 2009 22:19:24 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 27060 Received: (qmail 28136 invoked from network); 26 Jun 2009 22:19:23 -0000 Received: from bifrost.dotsrc.org (130.225.254.106) by sunsite.dk with SMTP; 26 Jun 2009 22:19:23 -0000 Received: from QMTA04.westchester.pa.mail.comcast.net (qmta04.westchester.pa.mail.comcast.net [76.96.62.40]) by bifrost.dotsrc.org (Postfix) with ESMTP id 65DFF8027106 for ; Sat, 27 Jun 2009 00:19:20 +0200 (CEST) Received: from OMTA13.westchester.pa.mail.comcast.net ([76.96.62.52]) by QMTA04.westchester.pa.mail.comcast.net with comcast id 8fnV1c00B17dt5G54mKL7Q; Fri, 26 Jun 2009 22:19:20 +0000 Received: from smtp.klanderman.net ([98.217.254.247]) by OMTA13.westchester.pa.mail.comcast.net with comcast id 8mKL1c0045M2Np63ZmKLuG; Fri, 26 Jun 2009 22:19:20 +0000 Received: from lwm.klanderman.net (unknown [192.168.100.50]) by smtp.klanderman.net (Postfix) with ESMTP id 2FA0DB3014A; Fri, 26 Jun 2009 18:19:19 -0400 (EDT) Received: by lwm.klanderman.net (Postfix, from userid 500) id 065429FC61E; Fri, 26 Jun 2009 18:19:19 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19013.18790.978774.551126@gargle.gargle.HOWL> Date: Fri, 26 Jun 2009 18:19:18 -0400 From: Greg Klanderman To: Zsh list Subject: need help debugging cvs completion problem Reply-To: gak@klanderman.net X-Mailer: VM 7.17 under 21.4 (patch 17) "Jumbo Shrimp" XEmacs Lucid X-Virus-Scanned: ClamAV 0.94.2/9510/Fri Jun 26 17:46:23 2009 on bifrost X-Virus-Status: Clean Hi, The ztrftime patch I just sent fixes one problem with cvs completion, in the _cvs_modified_entries function (used by 'cvs diff' completions), but there appears to be another problem in _cvs_existing_entries (used by 'cvs annotate' completions, for example). The variable 'pat' is being populated with the correct set of completions, however, the final line: (( ${#pat} )) && _wanted files expl file _path_files -a pat then results in all files (even those not under CVS control) being considered for completion. I assume this is some problem with _path_files, so am hoping someone might be able to at least tell me what the '-a' argument is supposed to be doing. At a higher level, if we already know the completions, why are we using _path_files in the first place here? thanks, Greg