From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-38472-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 7915 invoked by alias); 11 May 2016 15:15:15 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 38472
Received: (qmail 8351 invoked from network); 11 May 2016 15:15:14 -0000
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,
	T_DKIM_INVALID autolearn=ham autolearn_force=no version=3.4.1
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.co.uk; s=s2048; t=1462979336; bh=JqiyxasL1LxGqozgoATYC8B0SKDeN9GYkUAabnVDJAU=; h=In-reply-to:From:References:To:Subject:Date:From:Subject; b=R2EqUnrWKp2WzjaRc3wpXvnqhN4uQCp4OqroEGmufemsTKMVHuUoMh36dqiYpzA4tA454RlauCERVR9kPYCWaBdiSIJW9Z91wALd+v6As2TVHnNodvXj/TzHnk2XbtRsHSiQequwhTqiiYgWT+8w/RAVQ1+Tu+ed3brIxI28r/0Gun5Iz0Z+O14lQVCoOcISzFhEGB52uMJg2jijNBubHUiZkOOTk67WFcRq9EpU9mS5VWf0AAaa7gjTQaXhutgrM8deFbSRzk5npEn132z01ptiZU+j8x4UBHtLWILT9spxnUIe5y7ZePQjxgJ+BHBOORs91kj4eViqmwDYJLGiiw==
X-Yahoo-Newman-Id: 523955.7562.bm@smtp130.mail.ir2.yahoo.com
X-Yahoo-Newman-Property: ymail-3
X-YMail-OSG: 49C3VWkVM1lO3ga30O16co5pXduziImh9CGeYCSJzu31zCI
 2sWN7R1wiSOWAy2bDSPIlVhrQ6Wu4crljO3LNMy13SHz90_VdhYIG0ix4whQ
 5viKmDeXiHIQDImVog_wH.DBLoVhjJzgTF6JgSHRuF37yLrDeuQEHIsI0jWD
 8ZKGctB6lhqn6t.vhsDkJ0R4WmEyUQ5k0Ddi0OJeTd4CEJj0gApLLF13xiTv
 NeHUlRM4Klg_UtRgMoJh5VR4KpebsWvKae8tMDDfMiijfA4KRdtzpw2.9O1w
 HLPAFix6RtRhK7LBkUZc1Qnjy9gzc8vTMEQC_h7XkI8toUJFULjDK6Rn7tV.
 Z943nhntjk8IAa2S9PgZzN6V_D6r4ESDEL_YLPRI6xgQlD3zPGKAs.erd48f
 yIPs5y94eWGMCAYSlzoofB0vgqHQDAHQg98ebSlOLahR8HrXS_SRh82Jt2XT
 u07NuxcB281697s6kmX5uKT6Zhqoln0xNzF0sMAk_pbwl9cznbz7mZk7BrxC
 by1SQAjTSvF8YRC14NAXgMX0hjceaPQ--
X-Yahoo-SMTP: opAkk_CswBAce_kJ3nIPlH80cJI-
In-reply-to: <87eg9dmt6f.fsf@ft.bewatermyfriend.org>
From: Oliver Kiddle <okiddle@yahoo.co.uk>
References: <87k2jegi5h.fsf@ft.bewatermyfriend.org> <1462109252-12482-1-git-send-email-ft@bewatermyfriend.org> <27858.1462193719@thecus.kiddle.eu> <87eg9dmt6f.fsf@ft.bewatermyfriend.org>
To: zsh-workers@zsh.org
Subject: Re: [PATCHv3] Refactor baud rate completion
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <19156.1462979335.1@thecus.kiddle.eu>
Date: Wed, 11 May 2016 17:08:55 +0200
Message-ID: <19157.1462979335@thecus.kiddle.eu>

On 7 May, Frank Terbeck wrote:
> I don't know if there is a simple way to make it work the way I'd like
> (unsorted group as well as inheriting the right description), so I ended
> up doing this:
>
>     _description -1V baud-rates expl 'baud rate'
>     compadd "${(@)argv/#-J/-V}" "$expl[@]" -- "${rates[@]}"
>
> That feels pretty dirty, but it seems to work.

That looks like the best approach to me. It's the compadd interface
that's dirty and we're too late to fix that.

> The completion-style-guide mentions the following:
>
>     _description -1V tag expl '...'
>     compadd "$expl[@]" - ...
>
> But that would discard any descriptions given in an _arguments call.

The style guide could be improved to recommend passing on the
arguments.

Oliver