From: Peter Stephenson <pws@csr.com>
To: robert.schmertz@terpalum.umd.edu, zsh-workers@sunsite.dk
Subject: Re: Change in glibc's strncmp -> segfault?
Date: Tue, 20 Jan 2004 10:57:39 +0000 [thread overview]
Message-ID: <19217.1074596259@csr.com> (raw)
In-Reply-To: "Bob Schmertz"'s message of "Tue, 20 Jan 2004 01:24:48 PST." <20040120092448.40632.qmail@web12405.mail.yahoo.com>
Bob Schmertz wrote:
> I man page for strcmp on my Linux system, and it doesn't say anything
> about the behavior of strcmp or stsrncmp when null pointers are passed.
> But sometimes you call add_match_part explicitly with NULL parameters for
> the first six params. Two of these are immediately passed into a strncmp
> call.
You're right, that's weird. I've applied your change, since it looks
like the intention is either both pointers are NULL or neither.
The author for that part of the shell went off to do some real work a
couple of years ago.
--
Peter Stephenson <pws@csr.com> Software Engineer
CSR Ltd., Science Park, Milton Road,
Cambridge, CB4 0WH, UK Tel: +44 (0)1223 692070
**********************************************************************
The information transmitted is intended only for the person or
entity to which it is addressed and may contain confidential
and/or privileged material.
Any review, retransmission, dissemination or other use of, or
taking of any action in reliance upon, this information by
persons or entities other than the intended recipient is
prohibited.
If you received this in error, please contact the sender and
delete the material from any computer.
**********************************************************************
prev parent reply other threads:[~2004-01-20 10:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-20 9:24 Bob Schmertz
2004-01-20 10:57 ` Peter Stephenson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19217.1074596259@csr.com \
--to=pws@csr.com \
--cc=robert.schmertz@terpalum.umd.edu \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).