zsh-workers
 help / color / mirror / code / Atom feed
From: Oliver Kiddle <okiddle@yahoo.co.uk>
To: zsh-workers@zsh.org
Subject: Re: Subversion completion don't work with UTF8 (and other) file names
Date: Sat, 04 May 2013 04:15:01 +0200	[thread overview]
Message-ID: <19868.1367633701@thecus.kiddle.eu> (raw)
In-Reply-To: <20130429095741.7867e358@pwslap01u.europe.root.pri>

On 29 Apr, Peter Stephenson wrote:
> > > Unsetting all the LC_* variables (including LC_ALL) and setting only
> > > LC_CTYPE and LANG should be good enough, shouldn't it?  Something like:
> > > 
> > > _comp_locale() {
> > >    # This exports new locale settings, so should only
> > >    # be run in a subshell.  A typical use is in a $(...).
> > >    local ctype=${${(f)"$(locale 2>/dev/null)"}:#^LC_CTYPE=*}
> > >    unset -m LC_\*
> > >    [[ -n $ctype ]] && eval export $ctype
> > >    export LANG=C
> > > }
> > 
> Here's a change for _subversion only, if this works we can expand the
> use.

Is the locale command that portable?.
I'm not sure this is even necessary in the cases where it is just calling
svnadmin help or svn help rather than svn status.

Originally, _subversion set LC_MESSAGES for these commands but LC_ALL
overrides LC_MESSAGES. Would it be better to do it as follows:
  LC_CTYPE=${LC_ALL:-${LC_CTYPE:-$LANG}} LC_ALL= LC_MESSAGES=C _call_program ...

Or should we change the patterns so they'll work even with output in
other languages. For svn status, the changelists are introduced with
lines starting '---' and for svn help, sub commands all start with
three spaces so that may be the best option.

Oliver


  parent reply	other threads:[~2013-05-04  2:22 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-26 11:51 Paul Romanchenko
2013-04-26 12:39 ` Vincent Lefevre
2013-04-26 14:44   ` Peter Stephenson
2013-04-26 15:35     ` Vincent Lefevre
2013-04-29  8:57       ` Peter Stephenson
2013-04-29 13:58         ` Bart Schaefer
2013-05-04  2:15         ` Oliver Kiddle [this message]
2013-05-04 13:23           ` Peter Stephenson
2013-05-07  7:38             ` Oliver Kiddle
2013-05-07  9:21               ` Peter Stephenson
2013-05-14 13:28                 ` Vincent Lefevre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=19868.1367633701@thecus.kiddle.eu \
    --to=okiddle@yahoo.co.uk \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).