From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4899 invoked by alias); 4 May 2013 02:22:19 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 31367 Received: (qmail 14827 invoked from network); 4 May 2013 02:22:12 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE, T_TO_NO_BRKTS_FREEMAIL autolearn=ham version=3.3.2 Received-SPF: none (ns1.primenet.com.au: domain at yahoo.co.uk does not designate permitted sender hosts) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.co.uk; s=s1024; t=1367633702; bh=jVNphGKnwRIpsf4l5CCPZ6JWI+1Y5l+HOAqF82Cil2k=; h=X-Yahoo-Newman-Id:X-Yahoo-Newman-Property:X-YMail-OSG:X-Yahoo-SMTP:X-Rocket-Received:Received:In-reply-to:From:References:To:Subject:MIME-Version:Content-Type:Content-ID:Date:Message-ID; b=I1Fpe3PczX/XLOsHhgnP3R6HjHwkm4N26Qkv3EqbAAny4dWPmxQ89HK3muncWqEyooKXpINP3dub/Lx6OBJvWJN7xgshfQ4UqEcCmgSqkCeyLABKTM/6tCIicdUXBFdPRtyMUvYaMpA++LW6cmRrrIYZhU1mQEeYHthTknibSwc= X-Yahoo-Newman-Id: 747968.40486.bm@smtp125.mail.ird.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: fRpsV3UVM1n7yFGXK8nncJlxwlD7QYNHa9VQ0T6pRmT4yQE YlFKNKcX1PhLcH6yFT74Y2QV1ygw5RQ7p812pAHKtgOwzSzAU8Yk7FhTvIWF UvrO7hlzSBM5zgD8vcKa74tF1oHkp091b6QUMmEkz38jTxRcKd1r8OUXRljO q7dT86ig9eAcpsfbJ4vAnRpmFvWfr6ylq0EchAMezqbXqZ2I2zMhcys9v7GD bBzi4agvwMhp471v.mPw6tLqwWCmzZbfG8JwGb9lUTStu9Ct5XUn9RRQ8GTE YuZeWwopAH5pINGtXKVjDhTOJtsNfojJZZjkVZfTnPFAC5DHJwlg1_8ogjQf aqlvHkINnituKFnRlMeN2ZUw.nvIwAEuCyfJRSEjp_chgzKMuHT5eUzRk4YV U4utBXBqHJ5jlkYO5RUFJ6VL7Uo5KCqRRjVSChf9AOvFZyA-- X-Yahoo-SMTP: opAkk_CswBAce_kJ3nIPlH80cJI- X-Rocket-Received: from kiddle.eu (okiddle@94.79.136.60 with plain) by smtp125.mail.ird.yahoo.com with SMTP; 03 May 2013 19:15:02 -0700 PDT In-reply-to: <20130429095741.7867e358@pwslap01u.europe.root.pri> From: Oliver Kiddle References: <20130426123921.GT16210@xvii.vinc17.org> <20130426154427.06972873@pwslap01u.europe.root.pri> <20130426153546.GV16210@xvii.vinc17.org> <20130429095741.7867e358@pwslap01u.europe.root.pri> To: zsh-workers@zsh.org Subject: Re: Subversion completion don't work with UTF8 (and other) file names MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <19860.1367633691.1@thecus.kiddle.eu> Date: Sat, 04 May 2013 04:15:01 +0200 Message-ID: <19868.1367633701@thecus.kiddle.eu> On 29 Apr, Peter Stephenson wrote: > > > Unsetting all the LC_* variables (including LC_ALL) and setting only > > > LC_CTYPE and LANG should be good enough, shouldn't it? Something like: > > > > > > _comp_locale() { > > > # This exports new locale settings, so should only > > > # be run in a subshell. A typical use is in a $(...). > > > local ctype=${${(f)"$(locale 2>/dev/null)"}:#^LC_CTYPE=*} > > > unset -m LC_\* > > > [[ -n $ctype ]] && eval export $ctype > > > export LANG=C > > > } > > > Here's a change for _subversion only, if this works we can expand the > use. Is the locale command that portable?. I'm not sure this is even necessary in the cases where it is just calling svnadmin help or svn help rather than svn status. Originally, _subversion set LC_MESSAGES for these commands but LC_ALL overrides LC_MESSAGES. Would it be better to do it as follows: LC_CTYPE=${LC_ALL:-${LC_CTYPE:-$LANG}} LC_ALL= LC_MESSAGES=C _call_program ... Or should we change the patterns so they'll work even with output in other languages. For svn status, the changelists are introduced with lines starting '---' and for svn help, sub commands all start with three spaces so that may be the best option. Oliver