zsh-workers
 help / color / mirror / code / Atom feed
From: "Zvi Har'El" <rl@leeor.technion.ac.il>
To: P.Stephenson@swansea.ac.uk
Cc: zsh-workers@math.gatech.edu
Subject: Re: Small bug in zsh 2.6beta9
Date: Wed, 7 Jun 1995 12:40:00 +0300 (EET DST)	[thread overview]
Message-ID: <199506070940.MAA08544@leeor.technion.ac.il> (raw)
In-Reply-To: <21569.9506050937@pyro.swan.ac.uk> from "P.Stephenson@swansea.ac.uk" at Jun 5, 95 10:37:34 am

Peter,

YOU were right all the time. The two lines of code are identical. Perhaps
the idiom of checking if(a) rather then if(a!=0) is not clear to people
who are not seasoned C programmers, but personally I prefer your original code.


On Mon Jun  5 12:37:34 1995, P.Stephenson@swansea.ac.uk wrote about ``Re: Small bug in zsh 2.6beta9'':
> 
> heiko@pool.informatik.rwth-aachen.de wrote:
> > In the file exec.c, line 493, the line
> > 
> >     if (ornext ^ ret) {
> > 
> > should read
> > 
> >     if (ornext ^ (ret!=0)) {
> 
> You're quite right --- this is my fault again.  Here's an actual patch
> for that.
> 
> *** Src/exec.c.ret	Mon Jun  5 10:16:14 1995
> --- Src/exec.c	Mon Jun  5 10:34:30 1995
> ***************
> *** 506,512 ****
>   	     */
>   	    ornext = (slist->type == ORNEXT);
>   
> ! 	    if (ornext ^ ret) {
>   		/*
>   		 * If either (1) it's an or, and the return code
>   		 * was zero, or (2) it's an and, and the return
> --- 506,512 ----
>   	     */
>   	    ornext = (slist->type == ORNEXT);
>   
> ! 	    if (ornext ^ (ret != 0)) {
>   		/*
>   		 * If either (1) it's an or, and the return code
>   		 * was zero, or (2) it's an and, and the return
> 
> -- 
> Peter Stephenson <P.Stephenson@swansea.ac.uk>  Tel: +44 1792 205678 extn. 4461
> WWW:  http://python.swan.ac.uk/~pypeters/      Fax: +44 1792 295324
> Department of Physics, University of Wales, Swansea,
> Singleton Park, Swansea, SA2 8PP, U.K.
> 
> 
> 


-- 
Dr. Zvi Har'El <rl@math.technion.ac.il>              Department of Mathematics
+972-4-294094(Phone)                 Technion - Israel Institute of Technology
+972-4-324654(FAX)     http://gauss.technion.ac.il/~rl     Haifa 32000, ISRAEL
``If you can't say somethin' nice, don't say nothin' at all.''--Thumper (1942)


  reply	other threads:[~1995-06-07  9:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
1995-06-05  7:52 Heiko Schroeder
1995-06-05  9:37 ` P.Stephenson
1995-06-07  9:40   ` Zvi Har'El [this message]
1995-06-07 10:10     ` Bas V. de Bakker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=199506070940.MAA08544@leeor.technion.ac.il \
    --to=rl@leeor.technion.ac.il \
    --cc=P.Stephenson@swansea.ac.uk \
    --cc=zsh-workers@math.gatech.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).