From: Richard Coleman <coleman@math.gatech.edu>
To: zsh-workers@math.gatech.edu
Subject: Re: Pid or not pid
Date: Thu, 16 Nov 1995 18:57:35 -0500 [thread overview]
Message-ID: <199511162357.SAA01359@redwood.skiles.gatech.edu> (raw)
In-Reply-To: Your message of "Thu, 16 Nov 1995 16:57:47 +0100." <9511161557.AA20201@sgi.ifh.de>
> Some of the code in execcmd() is getting executed in the parent rather
> than the child, presumably since the last rearrangement... in
> particular, nice(5) is getting called if fork() returned a non-zero
> pid, i.e. in the parent (line 1350 of exec.c). This means each time a
> background process is forked, the parent shell has a lower priority.
> This may be a good way to deal with process hogs, but I don't think
> it's what's intended.
This is for beta12-test2. This bug is not present in beta10 or beta11.
rc
*** exec.c 1995/11/16 03:31:23 1.89
--- exec.c 1995/11/16 22:05:14
***************
*** 1345,1353 ****
read(synch[0], &dummy, 1);
close(synch[0]);
if (how & Z_ASYNC) {
- /* Check if we should run this job at a lower priority */
- if (isset(BGNICE))
- nice(5);
lastpid = pid;
} else if (!jobtab[thisjob].stty_in_env && nonempty(cmd->vars)) {
/* search for STTY=... */
--- 1345,1350 ----
***************
*** 1367,1372 ****
--- 1364,1373 ----
forked = 1;
if (sigtrapped[SIGINT] == 2)
holdintr();
+ /* Check if we should run background jobs at a lower priority. */
+ if ((how & Z_ASYNC) && isset(BGNICE))
+ nice(5);
+
} else if (is_cursh) {
/* This is a current shell procedure that didn't need to fork. *
* This includes current shell procedures that are being exec'ed, *
prev parent reply other threads:[~1995-11-17 0:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
1995-11-16 15:57 Peter William Stephenson
1995-11-16 18:25 ` Richard Coleman
1995-11-16 21:35 ` Zefram
1995-11-16 23:57 ` Richard Coleman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=199511162357.SAA01359@redwood.skiles.gatech.edu \
--to=coleman@math.gatech.edu \
--cc=zsh-workers@math.gatech.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).