multi-line history storing bug (beta13)

multi-line history storing bug (beta13)

[Geoff Wing]

Heyla, doing this on my machine loses the last line in the history list.

% for I in test
do echo hi
#test
done
%

It seems to happen in multiline editing when I put in a comment. Anyone else
get this?
-- 
Mason [G.C.W]  mason@werple.mira.net.au    "Hurt...Agony...Pain...LOVE-IT"

Re: multi-line history storing bug (beta13)

[Zefram]

>% for I in test
>do echo hi
>#test
>done
>%
>
>It seems to happen in multiline editing when I put in a comment. Anyone else
>get this?

I have been seeing similar things happen with no comment involved, but
the comment is the only reproducible pattern I've seen.  This needs
fixing, urgently.

-zefram

Re: multi-line history storing bug (beta13)

[Peter Stephenson]

mason@werple.net.au wrote:
> Heyla, doing this on my machine loses the last line in the history list.
> 
> % for I in test
> do echo hi
> #test
> done
> %
> 
> It seems to happen in multiline editing when I put in a comment. Anyone else
> get this?

It needs to pretend the newline character at the end of the comment is
a word, like other newlines.  (If it doesn't count the newline as a
word, it'll assume that the text ends with the previous word.)  I
didn't do that much detailed checking with multi line buffers, or with
interactivecomments.

*** Src/lex.c.icom	Thu Dec 21 23:44:21 1995
--- Src/lex.c	Mon Jan 15 16:49:00 1996
***************
*** 379,384 ****
--- 379,385 ----
  	    peek = LEXERR;
  	else {
  	    hwend();
+ 	    hwbegin(0);
  	    hwaddc('\n');
  	    peek = NEWLIN;
  	}


-- 
Peter Stephenson <pws@ifh.de>       Tel: +49 33762 77366
WWW:  http://www.ifh.de/~pws/       Fax: +49 33762 77330
Deutches Electronen-Synchrotron --- Institut fuer Hochenergiephysik Zeuthen
DESY-IfH, 15735 Zeuthen, Germany.

Re: multi-line history storing bug (beta13)

[yamagata]

Hello,

>> Heyla, doing this on my machine loses the last line in the history list.
>> 
>> % for I in test
>> do echo hi
>> #test
>> done
>> %
>> 
>> It seems to happen in multiline editing when I put in a comment. Anyone else
>> get this?

> It needs to pretend the newline character at the end of the comment is
> a word, like other newlines.  (If it doesn't count the newline as a
> word, it'll assume that the text ends with the previous word.)  I
> didn't do that much detailed checking with multi line buffers, or with
> interactivecomments.

I applied this patch, but still
zsh loss all lines except last, like this.
% sed '
s/:.*//
s/!.*//
' .newsrc

--
yamagata

Re: multi-line history storing bug (beta13)

[yamagata]

Sorry, this is only my mistake.

When I make zsh using gcc for pentium optimizing (gcc-2.6.3i) with -O3
option, it lose line.

Zsh made using gcc of FreeBSD doesnt produse this.

>> It needs to pretend the newline character at the end of the comment is
>> a word, like other newlines.  (If it doesn't count the newline as a
>> word, it'll assume that the text ends with the previous word.)  I
>> didn't do that much detailed checking with multi line buffers, or with
>> interactivecomments.

> I applied this patch, but still
> zsh loss all lines except last, like this.
> % sed '
> s/:.*//
> s/!.*//
> ' .newsrc

-
yamagata