TCCLEAREOD in zle_refresh.c/refresh()

TCCLEAREOD in zle_refresh.c/refresh()

[Carl Edman]

In beta13 this function contains these lines:

        if (!clearflag)
            if (tccan(TCCLEAREOD))
                tcout(TCCLEAREOD);
            else
                cleareol = 1;   /* set */

The effect is to have every prompt clear to the end of screen.  That  
causes display glitches under several terminal emulators with scroll-back  
buffers.   I replaced the TCCLEAREOD with TCCLEAREOL which fixes that  
problem without any apparent unwelcome side-effects.

But then I'm not an expert on this section of the code, so maybe there is  
a good, non-obvious reason that this has to be TCCLEAREOD ?  Unless there  
is an outcry of complaint, I'll submit a two-line patch in a few days.

	Carl Edman

Re: TCCLEAREOD in zle_refresh.c/refresh()

[Geoff Wing]

>From article 753 (and 756):
:In beta13 this function contains these lines:
:        if (!clearflag)
:            if (tccan(TCCLEAREOD))
:                tcout(TCCLEAREOD);
:            else
:                cleareol = 1;   /* set */
:The effect is to have every prompt clear to the end of screen.  That  
:causes display glitches under several terminal emulators with scroll-back  
:buffers.   I replaced the TCCLEAREOD with TCCLEAREOL which fixes that  
:problem without any apparent unwelcome side-effects.
:
:But then I'm not an expert on this section of the code, so maybe there is  
:a good, non-obvious reason that this has to be TCCLEAREOD ?  Unless there  
:is an outcry of complaint, I'll submit a two-line patch in a few days.

Not a good idea, and it should remain CLEAREOD.  If you can't handle
CLEAREOD because it affects your scrollback, one option may be to
disable it in your termcap/terminfo.  Most other things that need to clear
the screen will use a different terminal capability.

Re: TCCLEAREOD in zle_refresh.c/refresh()

[Carl Edman]

There was no outcry of complaint when I proposed this a couple days ago,  
so I assume nobody objects.  Here is the tiny unified diff patch:

--- zle_refresh.c.orig  Fri Feb  2 11:16:08 1996
+++ zle_refresh.c       Fri Feb  2 11:17:01 1996
@@ -192,8 +192,8 @@
        resetneeded = 0;        /* unset */
        oput_rpmpt = 0;         /* no right-prompt currently on screen */
         if (!clearflag)
-            if (tccan(TCCLEAREOD))
-                tcout(TCCLEAREOD);
+            if (tccan(TCCLEAREOL))
+                tcout(TCCLEAREOL);
             else
                 cleareol = 1;   /* set */
         if (t0 > -1)


Please include it in beta14.

	Carl Edman