From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from euclid.skiles.gatech.edu (list@euclid.skiles.gatech.edu [130.207.146.50]) by melb.werple.net.au (8.7.5/8.7.3) with ESMTP id SAA23494 for ; Wed, 8 May 1996 18:14:53 +1000 (EST) Received: (from list@localhost) by euclid.skiles.gatech.edu (8.7.3/8.7.3) id DAA00668; Wed, 8 May 1996 03:54:48 -0400 (EDT) Resent-Date: Wed, 8 May 1996 03:54:48 -0400 (EDT) Message-Id: <199605080754.DAA00652@euclid.skiles.gatech.edu> Date: Wed, 8 May 1996 09:54:15 +0200 From: "Bas V. de Bakker" To: zsh-workers@math.gatech.edu In-Reply-To: Peter Stephenson's message of Tue, 07 May 1996 16:52:40 +0200 Subject: Macros (Was: fdtable) References: <199605070817.KAA08463@hydra.ifh.de> <199605071452.QAA20774@hydra.ifh.de> Resent-Message-ID: <"kF7UF2.0.MA.7D5an"@euclid> Resent-From: zsh-workers@math.gatech.edu X-Mailing-List: archive/latest/1006 X-Loop: zsh-workers@math.gatech.edu Precedence: list Resent-Sender: zsh-workers-request@math.gatech.edu Peter Stephenson writes: > + /* Define to nothing if compiler does not handle `signed' keyword */ > + #undef signed > + There's already another fix by Zoltan, so the following remark no longer applies to this case, but I'd like to make a general remark here: When reading other people's code, I've regularly been bitten by the fact that the code was not what it looked like, due to a #define in one of the so many header files that was (directly or indirectly) included. The potential for errors is much less if one keeps all macros uppercase. So create a SIGNED macro that is either defined to signed or to nothing, like EXTERN. The same is true of things like #define dirent direct #define setpgrp setpgid which are currently used. Bas.