zsh-workers
 help / color / mirror / code / Atom feed
From: Anthony Heading <aheading@jpmorgan.com>
To: jussa@lenkkari.cs.tut.fi (Juha Leskel{)
Cc: zsh-workers@math.gatech.edu
Subject: Re: Directory stack and pushd/popd in zsh-2.6-beta17
Date: Fri, 10 May 1996 16:19:38 +0100 (BST)	[thread overview]
Message-ID: <199605101519.QAA09137@et-sun4.uk.jpmorgan.com> (raw)
In-Reply-To: <199605100951.AA157121909@lenkkari.cs.tut.fi> from "Juha Leskel{" at May 10, 96 12:51:48 pm

> Then to questions. I noticed that in this release popd builtin doesn't work
> as it used to. It really doesn't change the working directory. I tried it
> with and without pushd command ( I have autopushd option set ), but the
> result was the same. I also tried to unset autopushd option and without my
> chpwd function. I checked what is happening to the directory stack and
> here is something funny:
> 

Shoot!  This is my fault I think. At least it seems to be if you have
CHASE_LINKS set. 

The problem appears to be that I changed cd_get_dest to return the "targetted"
entry on the directory stack.  For cd and pushd this is fine. But for popd, that's
the directory to be killed, not to be changed to.  So the code is going through
the machinations of changing to this wrong dir, but the day is saved in bin_cd(),
which actually changes to the correct dir, *except* if CHASE_LINKS is set.

I'll try to work out a fix this weekend.  It might involve restructuring that
whole section of code, since the way it's split into multiple functions is
actually rather unhelpful. 

Just in case I'm about to screw up, could someone tell me what that code at the end
of bin_cd() ( stat() and stat() and notequal and chdir() ) is supposed to catch?
I can't see why the previous functions shouldn't do the job properly.

Sorry about this. Any input or suggestions from anyone who cares to look at it
happily taken on board...

Anthony




      reply	other threads:[~1996-05-10 15:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
1996-05-10  9:51 Juha Leskel{
1996-05-10 15:19 ` Anthony Heading [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=199605101519.QAA09137@et-sun4.uk.jpmorgan.com \
    --to=aheading@jpmorgan.com \
    --cc=jussa@lenkkari.cs.tut.fi \
    --cc=zsh-workers@math.gatech.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).