zsh-workers
 help / color / mirror / code / Atom feed
From: Wayne Davison <wayne@tenor.clarinet.com>
To: Zefram <A.Main@dcs.warwick.ac.uk>
Cc: Z Shell workers mailing list <zsh-workers@math.gatech.edu>
Subject: Re: ZLE 8-bit patch
Date: Fri, 10 May 1996 14:12:47 -0700	[thread overview]
Message-ID: <199605102112.OAA01273@tenor.clari.net> (raw)
In-Reply-To: A.Main's message of Fri, 10 May 1996 10:39:17 +0100. <23053.199605100939@stone.dcs.warwick.ac.uk>

Zefram writes:
> The i-search code is now a real mess.
> Someone should review/rewrite the code properly.

I'm fiddling with it now.  If anyone else is working on it, let me know.

Also, I discovered that your DEBUG code in zstrlen() isn't checking
the error condition correctly.  Here's a patch:

Index: utils.c
@@ -2936,11 +2936,12 @@
 
     for (l = 0; *s; l++)
 	if (*s++ == Meta) {
-	    s++;
 #ifdef DEBUG
 	    if (! *s)
 		fprintf(stderr, "BUG: unexpected end of string in ztrlen()\n");
+	    else
 #endif
+	    s++;
 	}
     return l;
 }

..wayne..



  reply	other threads:[~1996-05-10 21:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
1996-05-10  9:39 Zefram
1996-05-10 21:12 ` Wayne Davison [this message]
1996-05-11  3:31 ` Updated isearch patch based on " Wayne Davison

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=199605102112.OAA01273@tenor.clari.net \
    --to=wayne@tenor.clarinet.com \
    --cc=A.Main@dcs.warwick.ac.uk \
    --cc=zsh-workers@math.gatech.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).