From: Richard Coleman <coleman@math.gatech.edu>
To: zsh-workers@math.gatech.edu
Subject: Re: clwords bugfix
Date: Sat, 25 May 1996 14:02:46 -0400 [thread overview]
Message-ID: <199605251802.OAA20740@redwood.skiles.gatech.edu> (raw)
In-Reply-To: Your message of "Sat, 25 May 1996 15:38:51 BST." <27894.199605251438@stone.dcs.warwick.ac.uk>
> There is a bug in zle_tricky.c (ooh, what a surprise). When the
> clwords array needs to be resized, the new part of the array is
> supposed to be initialised to NULLs. The current version has
> an off-by-one error, meaning that it clears the current element
> (which is immediately freed, so there is only a memory leak here),
> but it doesn't clear the new last element (this causes crashes).
> The patch below fixes this, and changes it to use a looped assignment
> rather than memset, as NULL is not all-bits-zero on all machines.
>
> -zefram
What Unix has a NULL that isn't all-bits-zero? That would break
a tremendous amount of code. There all lots of places in zsh
that assume this and use memset. I don't think we should change
this.
rc
next prev parent reply other threads:[~1996-05-25 18:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
1996-05-25 14:38 Zefram
1996-05-25 18:02 ` Richard Coleman [this message]
1996-05-25 20:52 ` Zefram
1996-05-25 21:25 ` (NULL == 0) ? Richard Coleman
1996-05-25 22:00 ` Zefram
1996-05-27 0:00 ` Zoltan Hidvegi
1996-05-27 6:39 ` Bart Schaefer
1996-05-27 7:29 ` anthony baxter
1996-05-27 13:07 ` Zefram
1996-05-27 22:00 ` Zoltan Hidvegi
1996-05-27 22:11 ` Zefram
1996-05-27 22:41 ` Zoltan Hidvegi
1996-05-27 22:54 ` Zefram
1996-05-28 4:54 ` Bart Schaefer
1996-05-27 23:36 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=199605251802.OAA20740@redwood.skiles.gatech.edu \
--to=coleman@math.gatech.edu \
--cc=zsh-workers@math.gatech.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).