zsh-workers
 help / color / mirror / code / Atom feed
From: Peter Stephenson <pws@ifh.de>
To: zsh-workers@math.gatech.edu (Zsh hackers list)
Subject: arr=('') broken
Date: Fri, 28 Jun 1996 16:52:14 +0200	[thread overview]
Message-ID: <199606281452.QAA23567@hydra.ifh.de> (raw)

Assigning empty strings to arrays (set -A still works OK) was broken
by the changes in untokenisation.  This broke my multicomp function.

% sofar=('')
% print $#sofar
0

The patch should be something like the following.  I've written it
this way on the assumption that if we get as far as the array code,
the list must have passed through globlist and hence has had unwanted
elements pruned already.  As I understand it, globlist() now always
returns untokenised text, and one needs to be careful not to
untokenise twice which can in principal do bad things to
eight-bit-cleanliness, which is why I added the first hunk and removed
the untokenize() in the second hunk.

*** Src/exec.c~	Fri Jun 21 10:47:16 1996
--- Src/exec.c	Fri Jun 28 16:46:44 1996
***************
*** 1047,1053 ****
  	    if (empty(vl))
  		val = ztrdup("");
  	    else {
! 		untokenize(peekfirst(vl));
  		val = ztrdup(ugetnode(vl));
  	    }
  	    if (xtr)
--- 1047,1054 ----
  	    if (empty(vl))
  		val = ztrdup("");
  	    else {
! 		if (!isset(GLOBASSIGN))
! 		    untokenize(peekfirst(vl));
  		val = ztrdup(ugetnode(vl));
  	    }
  	    if (xtr)
***************
*** 1066,1075 ****
  	    char *pp;
  
  	    pp = (char *) ugetnode(vl);
! 	    if (*pp) {
! 		*ptr = ztrdup(pp);
! 		untokenize(*ptr++);
! 	    }
  	}
  	*ptr = NULL;
  	if (xtr) {
--- 1067,1073 ----
  	    char *pp;
  
  	    pp = (char *) ugetnode(vl);
! 	    *ptr++ = ztrdup(pp);
  	}
  	*ptr = NULL;
  	if (xtr) {

-- 
Peter Stephenson <pws@ifh.de>       Tel: +49 33762 77366
WWW:  http://www.ifh.de/~pws/       Fax: +49 33762 77330
Deutches Electronen-Synchrotron --- Institut fuer Hochenergiephysik Zeuthen
DESY-IfH, 15735 Zeuthen, Germany.



             reply	other threads:[~1996-06-28 15:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
1996-06-28 14:52 Peter Stephenson [this message]
1996-06-28 15:08 ` Zoltan Hidvegi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=199606281452.QAA23567@hydra.ifh.de \
    --to=pws@ifh.de \
    --cc=zsh-workers@math.gatech.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).