From: Zoltan Hidvegi <hzoli@cs.elte.hu>
To: pws@ifh.de (Peter Stephenson)
Cc: zsh-workers@math.gatech.edu
Subject: Re: Lethal option-related bug
Date: Mon, 29 Jul 1996 20:03:45 +0200 (MET DST) [thread overview]
Message-ID: <199607291803.UAA05285@bolyai.cs.elte.hu> (raw)
In-Reply-To: <199607291559.RAA10028@hydra.ifh.de> from Peter Stephenson at "Jul 29, 96 05:59:28 pm"
> I just submitted a batch job for the first time with an unpatched
> 3.0-pre4 and it dumped core straight away. (I think the shell is
> still yelling out `Don't release me! Don't release me!'.)
OK, I'll make a 3.0-pre5 and will release 3.0 later in August.
> It turns out to be easy to reproduce:
>
> ./zsh -s
> zsh: 7863 segmentation fault (core dumped) ./zsh -s
[...]
> and the problem is that ifs is null in inittyptab; possibly not too
> surprising, since it gets initialised in setupvals(), which is called
> a few lines after parseargs() in main(). It looks like SHINSTDIN
> wants inittytab set up before the shell's set up enough for it.
>
> I could probably hack round this, but I'm not confident of producing
> the right fix, so I'll leave it.
OK, below is a simple and clean fix. POSIX says that if IFS is unset it
should be treated as if it were set to space-tab-newline. Zsh does this
but it adds an extra null here.
Zoltan
*** Src/zsh.h 1996/07/28 22:29:59 2.36
--- Src/zsh.h 1996/07/29 08:59:08
***************
*** 57,62 ****
--- 57,67 ----
#define Meta ((char) 0x83)
+ /* Note that the fourth character in DEFAULT_IFS is Meta *
+ * followed by a space which denotes the null character. */
+
+ #define DEFAULT_IFS " \t\n\203 "
+
/* Character tokens */
#define Pound ((char) 0x84)
#define String ((char) 0x85)
*** Src/utils.c 1996/07/21 15:00:57 2.46
--- Src/utils.c 1996/07/29 17:54:59
***************
*** 2507,2513 ****
typtab[STOUC(Meta)] |= IMETA;
for (t0 = (int)STOUC(Pound); t0 <= (int)STOUC(Nularg); t0++)
typtab[t0] |= ITOK | IMETA;
! for (s = ifs; *s; s++) {
if (inblank(*s))
if (s[1] == *s)
s++;
--- 2507,2513 ----
typtab[STOUC(Meta)] |= IMETA;
for (t0 = (int)STOUC(Pound); t0 <= (int)STOUC(Nularg); t0++)
typtab[t0] |= ITOK | IMETA;
! for (s = ifs ? ifs : DEFAULT_IFS; *s; s++) {
if (inblank(*s))
if (s[1] == *s)
s++;
*** Src/params.c 1996/07/25 18:22:08 2.30
--- Src/params.c 1996/07/29 17:55:53
***************
*** 1574,1583 ****
ifssetfn(Param pm, char *x)
{
zsfree(ifs);
! if (x)
! ifs = x;
! else
! ifs = ztrdup(" \t\n "), ifs[3] = Meta;
inittyptab();
}
--- 1574,1580 ----
ifssetfn(Param pm, char *x)
{
zsfree(ifs);
! ifs = x;
inittyptab();
}
*** Src/init.c 1996/07/27 20:24:36 2.35
--- Src/init.c 1996/07/29 17:57:54
***************
*** 520,527 ****
if (!(ttystrname = ztrdup(ttyname(SHTTY))))
ttystrname = ztrdup("");
! ifs = ztrdup(" \t\n ");
! ifs[3] = Meta;
wordchars = ztrdup(DEFAULT_WORDCHARS);
postedit = ztrdup("");
underscore = ztrdup("");
--- 520,526 ----
if (!(ttystrname = ztrdup(ttyname(SHTTY))))
ttystrname = ztrdup("");
! ifs = ztrdup(DEFAULT_IFS);
wordchars = ztrdup(DEFAULT_WORDCHARS);
postedit = ztrdup("");
underscore = ztrdup("");
next prev parent reply other threads:[~1996-07-29 18:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
1996-07-29 15:59 Peter Stephenson
1996-07-29 18:03 ` Zoltan Hidvegi [this message]
1996-07-30 8:19 ` Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=199607291803.UAA05285@bolyai.cs.elte.hu \
--to=hzoli@cs.elte.hu \
--cc=pws@ifh.de \
--cc=zsh-workers@math.gatech.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).