From: Geoff Wing <mason@primenet.com.au>
To: zsh-workers@math.gatech.edu
Cc: hoh@approve.se (Goran Larsson)
Subject: Re: bugs found
Date: Tue, 10 Sep 1996 20:25:09 +1000 (EST) [thread overview]
Message-ID: <199609101025.UAA04474@coral.primenet.com.au> (raw)
In-Reply-To: <no.id> from "mason" at Sep 4, 96 04:54:20 am
I wrote:
::From: hoh@approve.se (Goran Larsson)
::2)
:: $ PROMPT=AAA
:: AAA_
:: AAAPROMPT=AA
:: AA_
:: AAPROMPT=A
:: _
:: APROMPT='$'
:: APROMPT='$ '
:: $ _
:: Note that any one character prompt is replaced by a space.
:OK. I've found the problem (and another smaller one - the code gets to a
:place I commented as 'shouldn't happen' - now I've got to remember why :-)).
I am still not totally sure why I had it commented as `shouldn't happen'.
Most likely it would have had to do with cleareol stuff and it may be
redundant, but since it may not I've left it in.
:Patch in a day or so.
Or a bit longer.
*** zle_refresh.c.old Wed Sep 4 02:12:23 1996
--- zle_refresh.c Tue Sep 10 20:17:00 1996
***************
*** 515,521 ****
if (ln && nbuf[ln])
strncpy(nl, p1, winw + 1); /* next time obuf will be up-to-date */
else
! nl = p1; /* shouldn't happen */
nllen = winw;
} else if (ollen > nllen) { /* make new line at least as long as old */
p1 = halloc(ollen + 1);
--- 515,521 ----
if (ln && nbuf[ln])
strncpy(nl, p1, winw + 1); /* next time obuf will be up-to-date */
else
! nl = p1; /* don't keep padding for prompt line */
nllen = winw;
} else if (ollen > nllen) { /* make new line at least as long as old */
p1 = halloc(ollen + 1);
***************
*** 553,558 ****
--- 553,567 ----
if (*ol)
ol++;
ccs = 1;
+ }
+
+ /* 2c: if we're on the first line, start checking at the end of the prompt;
+ we shouldn't be doing anything within the prompt */
+
+ if (ln == 0 && pptw) {
+ nl += (pptw - ccs);
+ ol += (pptw - ccs);
+ ccs = pptw;
}
/* 3: main display loop - write out the buffer using whatever tricks we can */
--
Geoff Wing [mason@primenet.com.au] PrimeNet - Internet Consultancy
Web: http://www.primenet.com.au/ Facsimile: +61-3-9819 3788
next prev parent reply other threads:[~1996-09-10 10:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <no.id>
1996-05-23 0:34 ` compctl bug in 2.6-betat17 Zoltan Hidvegi
1996-09-10 10:25 ` Geoff Wing [this message]
1998-05-01 13:43 ` 3.1.3 - config.status file generation problems Andrew Main
1996-09-03 15:39 forwarded mail Richard Coleman
1996-09-03 18:54 ` bugs found Geoff Wing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=199609101025.UAA04474@coral.primenet.com.au \
--to=mason@primenet.com.au \
--cc=hoh@approve.se \
--cc=zsh-workers@math.gatech.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).