Re: compctl bug in 2.6-betat17

Re: compctl bug in 2.6-betat17

[Zoltan Hidvegi]

[-- Attachment #1: Type: application/pgp, Size: 3053 bytes --]

Re: bugs found

[Geoff Wing]

I wrote:
::From: hoh@approve.se (Goran Larsson)
::2)
::	$ PROMPT=AAA
::	AAA_
::	AAAPROMPT=AA
::	AA_
::	AAPROMPT=A
::	 _
::	 APROMPT='$'
::	 APROMPT='$ '
::	$ _
::	Note that any one character prompt is replaced by a space.
:OK. I've found the problem (and another smaller one - the code gets to a 
:place I commented as 'shouldn't happen' - now I've got to remember why :-)).

I am still not totally sure why I had it commented as `shouldn't happen'.
Most likely it would have had to do with cleareol stuff and it may be
redundant, but since it may not I've left it in.

:Patch in a day or so.

Or a bit longer.


*** zle_refresh.c.old	Wed Sep  4 02:12:23 1996
--- zle_refresh.c	Tue Sep 10 20:17:00 1996
***************
*** 515,521 ****
  	if (ln && nbuf[ln])
  	    strncpy(nl, p1, winw + 1);	/* next time obuf will be up-to-date */
  	else
! 	    nl = p1;		/* shouldn't happen */
  	nllen = winw;
      } else if (ollen > nllen) { /* make new line at least as long as old */
  	p1 = halloc(ollen + 1);
--- 515,521 ----
  	if (ln && nbuf[ln])
  	    strncpy(nl, p1, winw + 1);	/* next time obuf will be up-to-date */
  	else
! 	    nl = p1;		/* don't keep padding for prompt line */
  	nllen = winw;
      } else if (ollen > nllen) { /* make new line at least as long as old */
  	p1 = halloc(ollen + 1);
***************
*** 553,558 ****
--- 553,567 ----
  	if (*ol)
  	    ol++;
  	ccs = 1;
+     }
+ 
+ /* 2c: if we're on the first line, start checking at the end of the prompt;
+    we shouldn't be doing anything within the prompt */
+ 
+     if (ln == 0 && pptw) {
+ 	nl += (pptw - ccs);
+ 	ol += (pptw - ccs);
+ 	ccs = pptw;
      }
  
  /* 3: main display loop - write out the buffer using whatever tricks we can */
--
Geoff Wing [mason@primenet.com.au]   PrimeNet - Internet Consultancy
  Web: http://www.primenet.com.au/   Facsimile: +61-3-9819 3788

Re: 3.1.3 - config.status file generation problems...

[Andrew Main]

zefram wrote:
>It looks as if the shell you used to run the configure script has
>translated '\\' to '\' within single quotes, which is well out of order.
>Alternatively your ed has done the equivalent, which is also wrong.

On second thoughts, scratch that.  It's almost certainly echo that's
translating '\\' to '\'.  So the advice is, don't configure 3.1.3 with
a SysV sh.  zsh and bash will both work as intended (if invoked as sh).

Temporary fix: in the ed input in configure.in, change each '\' to '#',
and change ') | ed' to ') | sed s/\#/\\\\/g | ed'.  I'll produce a proper
patch when I have a chance to analyse it more thoroughly.

-zefram

Re: bugs found

[Geoff Wing]

:From: hoh@approve.se (Goran Larsson)
:Subject: Bugs in 3.0.0
[... first bug deleted ...]
:2)
:	$ PROMPT=AAA
:	AAA_
:	AAAPROMPT=AA
:	AA_
:	AAPROMPT=A
:	 _
:	 APROMPT='$'
:	 APROMPT='$ '
:	$ _
:
:	Note that any one character prompt is replaced by a space.

OK. I've found the problem (and another smaller one - the code gets to a 
place I commented as 'shouldn't happen' - now I've got to remember why :-)).
Patch in a day or so.

:3)
:	Sometimes filename completion acts up. It is kind of hard
:	to reproduce, but it goes something like this:

I've had hard to reproduce problems with this too, but I assumed it was
my compctl stuff which I really haven't checked properly.  When I get
time....

-- 
Geoff Wing [mason@primenet.com.au]   PrimeNet - Internet Consultancy
  Web: http://www.primenet.com.au/   Facsimile: +61-3-9819 3788