zsh-workers
 help / color / mirror / code / Atom feed
* getzlequery
@ 1996-10-15 13:51 Peter Stephenson
  1996-10-15 21:05 ` getzlequery Zoltan Hidvegi
  0 siblings, 1 reply; 2+ messages in thread
From: Peter Stephenson @ 1996-10-15 13:51 UTC (permalink / raw)
  To: Zsh hackers list

I'm getting a `test is always zero' message from getlzlequery() in
zle_utils.c due to testing whether a char is EOF.  This is something
to do with:

        * Src/utils.c: getquery always returned n on cray-unicos. From
          Richard D. Slater (2136)

Either the test shouldn't be there, or the variable c should be an
int, or the variable should be a signed char and we need to check
whether the compiler supports it (and we presumably lose the ability
to recognise character 255, so that's probably wrong).  I don't know
which avoids reintroducing the UNICOS problem.

-- 
Peter Stephenson <pws@ifh.de>       Tel: +49 33762 77366
WWW:  http://www.ifh.de/~pws/       Fax: +49 33762 77413
Deutches Electronen-Synchrotron --- Institut fuer Hochenergiephysik Zeuthen
DESY-IfH, 15735 Zeuthen, Germany.


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: getzlequery
  1996-10-15 13:51 getzlequery Peter Stephenson
@ 1996-10-15 21:05 ` Zoltan Hidvegi
  0 siblings, 0 replies; 2+ messages in thread
From: Zoltan Hidvegi @ 1996-10-15 21:05 UTC (permalink / raw)
  To: Peter Stephenson; +Cc: zsh-workers

Peter Stephenson wrote:
> I'm getting a `test is always zero' message from getlzlequery() in
> zle_utils.c due to testing whether a char is EOF.  This is something
> to do with:
> 
>         * Src/utils.c: getquery always returned n on cray-unicos. From
>           Richard D. Slater (2136)

I do not see the relation between these.  However the patch below should fix
that.

Zoltan


--- Src/zle_utils.c	1996/10/15 20:16:35	2.14
+++ Src/zle_utils.c	1996/10/15 20:59:31
@@ -309,7 +309,7 @@
 int
 getzlequery(void)
 {
-    char c;
+    int c;
 #ifdef FIONREAD
     int val;
 
@@ -332,5 +332,5 @@
 
     /* echo response and return */
     putc(c, shout);
-    return (int)c;
+    return c;
 }


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~1996-10-15 21:08 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
1996-10-15 13:51 getzlequery Peter Stephenson
1996-10-15 21:05 ` getzlequery Zoltan Hidvegi

Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).