zsh-workers
 help / color / mirror / code / Atom feed
* Re: bug fix for zsh 3.0.0
@ 1996-10-25 20:10 Keith Bostic
  1996-10-25 20:29 ` Zoltan Hidvegi
  0 siblings, 1 reply; 5+ messages in thread
From: Keith Bostic @ 1996-10-25 20:10 UTC (permalink / raw)
  To: hzoli; +Cc: zsh-workers

> Keith Bostic wrote:
>> Some termcap databases (e.g., the one distributed with ncurses) have
>> entries larger than 1K.  When combined with termcap library code that
>> doesn't limit the length of the copied record to 1K (e.g., old 4BSD
>> implementations) it can drop core.
>
> That can only happen if a single capability string is bigger thatn 1024
> bytes.  Did you really see a coredump from that part of the code or you
> just see it as a theoretical bug?

Single capability strings in some termcap databases are bigger
than 1K.  I really saw a coredump in a previous version of zsh.
The fix for that version was:

	--- ./src/zsh.h 1995/12/07 21:40:24     1.1
	+++ ./src/zsh.h 1996/10/23 16:18:58
	@@ -1855,7 +1855,7 @@
 
	 /* the termcap buffer */
 
	-EXTERN char termbuf[1024];
	+EXTERN char termbuf[4096];
 
	 /* $TERM */

--keith


^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: bug fix for zsh 3.0.0
@ 1996-10-25 20:39 Keith Bostic
  0 siblings, 0 replies; 5+ messages in thread
From: Keith Bostic @ 1996-10-25 20:39 UTC (permalink / raw)
  To: hzoli; +Cc: zsh-workers

> Show me an example.  A tercap string usually tells you things like how to
> move the cursor to a given screen position.  This is never that big.  What
> termcap feature has such a long string?

You're absolutely right, I misred the zsh code.  You've upgraded
the size of the termbuf array to 2K since the last version, which
is almost certainly large enough.

Thanks, and I apologize for the mistake!
--keith


^ permalink raw reply	[flat|nested] 5+ messages in thread
* bug fix for zsh 3.0.0
@ 1996-10-25 14:23 Keith Bostic
  1996-10-25 18:41 ` Zoltan Hidvegi
  0 siblings, 1 reply; 5+ messages in thread
From: Keith Bostic @ 1996-10-25 14:23 UTC (permalink / raw)
  To: zsh-workers

Some termcap databases (e.g., the one distributed with ncurses) have
entries larger than 1K.  When combined with termcap library code that
doesn't limit the length of the copied record to 1K (e.g., old 4BSD
implementations) it can drop core.

--keith

Index: init.c
===================================================================
RCS file: /master/contrib/zsh-3.0.0/Src/init.c,v
retrieving revision 1.1.1.1
retrieving revision 1.2
diff -c -r1.1.1.1 -r1.2
*** init.c	1996/10/02 17:10:14	1.1.1.1
--- init.c	1996/10/25 13:31:56	1.2
***************
*** 405,411 ****
  	errflag = 0;
  	return termok = TERM_BAD;
      } else {
! 	char tbuf[1024], *pp;
  	int t0;
  
  	termok = TERM_OK;
--- 405,411 ----
  	errflag = 0;
  	return termok = TERM_BAD;
      } else {
! 	char tbuf[4096], *pp;
  	int t0;
  
  	termok = TERM_OK;


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~1996-10-25 20:39 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
1996-10-25 20:10 bug fix for zsh 3.0.0 Keith Bostic
1996-10-25 20:29 ` Zoltan Hidvegi
  -- strict thread matches above, loose matches on Subject: below --
1996-10-25 20:39 Keith Bostic
1996-10-25 14:23 Keith Bostic
1996-10-25 18:41 ` Zoltan Hidvegi

Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).