Bug in 3.0.2-test1 (no 'erase char' if zle off)

Bug in 3.0.2-test1 (no 'erase char' if zle off)

[C. v. Stuckrad]

Hi!

I compiled 3.0.2-test1 (by first unpacking a 'fresh' 3.0.1 then doing
the big patch. The first 'hunk' in Etc/FAQ failed (I saw nothing which
'should' brak it, so may be there are some blanks or tabs ?)
The rest worked normally, even the OPEN_MAX did NOT need to be changed
(We needed it =64, an in 3.0.2 it seems to be default now).

Just now I started zsh-3.0.2-test1 on an terminal with 'dumb' $TERM
setting, so 'SINGLE-LINE-ZLE' was on. (The error does not depend on that,
it happens on every TERM, wherever '-M' is on.)

The result of switching '-M' on is:
- deleting 'backwards' the last char, just moves left
- deleting a char 'inside' the linne, moves the following chars left,
  BUT 'fills' with the last char (also does no 'blanking' of the last char)
- Control-U (erase line) only moves the cursor to the beginning of line
- Control-K (erase rest of line) does seemingly nothing

All the above do 'realize' the correct line, they only display wrongly.

Your's  Stucki

Christoph von Stuckrad       * *  | talk to  | <stucki@math.fu-berlin.de> \
Freie Universitaet Berlin    |/_* | nickname | ...!unido!fub!leibniz!stucki|
Fachbereich Mathematik, EDV  |\ * | 'stucki' | Tel:+49 30 838-7545{9|8}    |
Arnimallee 2-6/14195 Berlin  * *  |  on IRC  | Fax:+49 30 838-5913        /

Re: Bug in 3.0.2-test1 (no 'erase char' if zle off)

[gwing]

C. v. Stuckrad wrote:
:I compiled 3.0.2-test1 (by first unpacking a 'fresh' 3.0.1 then doing
:the big patch. The first 'hunk' in Etc/FAQ failed (I saw nothing which
:'should' brak it, so may be there are some blanks or tabs ?)

Yeah, that always fails if you start from the RCS version.  I don't know about
the other version.  That's because the patch contains a line with $Id$ , and
as soon as you check out the FAQ that line gets filled with RCS information
which is not static - eg. if you lock it, it will be different to an unlocked
version.

:The result of switching '-M' on is:
:- deleting 'backwards' the last char, just moves left
:- deleting a char 'inside' the linne, moves the following chars left,
:  BUT 'fills' with the last char (also does no 'blanking' of the last char)
:- Control-U (erase line) only moves the cursor to the beginning of line
:- Control-K (erase rest of line) does seemingly nothing

It occurs on my machine as well.  Annoying since I don't remember changing
(or anyone else changing) any code that would affect it.  
Ahh, it happened between 3.0.1-test4 and 3.0.1 - sometimes having 17 old
versions does something besides taking up disk space :-)
Hopefully a patch will follow soon.
-- 
Geoff Wing [gwing@primenet.com.au]   Technical Manager
  Phone    : +61-3-9818 2977	     PrimeNet - Internet Consultancy
  Facsimile: +61-3-9819 3788	     Web : <URL:http://www.primenet.com.au/>
  Mobile   : 0412 162 441

Re: Bug in 3.0.2-test1 (no 'erase char' if zle off)

[gwing]

I wrote:
:C. v. Stuckrad found some bugs.
:Hopefully a patch will follow soon.

Here it is.  It should be against 3.0.2-test1 (I think).  
One test I put in recently was a bit overeager.


*** zle_refresh.c.1	Mon Dec  9 23:20:27 1996
--- zle_refresh.c	Mon Dec  9 23:35:46 1996
***************
*** 58,64 ****
      pptw, rpw,                  /* prompt widths on screen                  */
      vcs, vln,			/* video cursor position column & line	    */
      vmaxln,			/* video maximum number of lines	    */
!     winw, winh,			/* window width & height		    */
      winpos;			/* singlelinezle: line's position in window */
  static unsigned pmpt_attr = 0,	/* text attributes after displaying prompt  */
      rpmpt_attr = 0;		/* text attributes after displaying rprompt */
--- 58,64 ----
      pptw, rpw,                  /* prompt widths on screen                  */
      vcs, vln,			/* video cursor position column & line	    */
      vmaxln,			/* video maximum number of lines	    */
!     winw, winh, rwinh,		/* window width & height		    */
      winpos;			/* singlelinezle: line's position in window */
  static unsigned pmpt_attr = 0,	/* text attributes after displaying prompt  */
      rpmpt_attr = 0;		/* text attributes after displaying rprompt */
***************
*** 76,81 ****
--- 76,82 ----
  	winh = 1;
      else
  	winh = (lines < 2) ? 24 : lines;
+     rwinh = lines;		/* keep the real number of lines */
      winpos = vln = vmaxln = 0;
      if (lwinw != winw || lwinh != winh) {
  	if (nbuf) {
***************
*** 275,281 ****
  	}
  	fflush(shout);
  	clearf = clearflag;
!     } else if (winw != columns || winh != lines)
  	resetvideo();
  
  /* now winw equals columns and winh equals lines 
--- 276,282 ----
  	}
  	fflush(shout);
  	clearf = clearflag;
!     } else if (winw != columns || rwinh != lines)
  	resetvideo();
  
  /* now winw equals columns and winh equals lines 

-- 
Geoff Wing [gwing@primenet.com.au]   Technical Manager
  Phone    : +61-3-9818 2977	     PrimeNet - Internet Consultancy
  Facsimile: +61-3-9819 3788	     Web : <URL:http://www.primenet.com.au/>
  Mobile   : 0412 162 441