From: Zoltan Hidvegi <hzoli@cs.elte.hu>
To: zefram@dcs.warwick.ac.uk (Zefram)
Cc: zefram@dcs.warwick.ac.uk, zsh-workers@math.gatech.edu
Subject: Re: linked-in modules
Date: Tue, 24 Dec 1996 04:01:42 +0100 (MET) [thread overview]
Message-ID: <199612240301.EAA02653@hzoli.ppp.cs.elte.hu> (raw)
In-Reply-To: <4422.199612232007@stone.dcs.warwick.ac.uk> from Zefram at "Dec 23, 96 08:07:23 pm"
Zefram write:
> Zoltan Hidvegi wrote:
> >This Makefile will soon become the most complicated part of zsh.
>
> You mean it's not already? (I have another patch planned which will
Well there are still some trickery in exec.c which I'd like to understand
better. Unfortunately with my previous patch in my attempt to get parallel
make work I did too much and make always wants to rebuild everything. The
patch below backs up a bit so that parallel make will not work again (but
make -j3 proto && make -j3 still works).
> make it even worse.)
Oh!
> >! MODULE_DIRS = Modules Zle
> >--- 154,160 ----
> >! MODULE_DIRS = $(MODULE_DIR) Zle
>
> Why is Src/Modules identified as $(MODULE_DIR)? We already have two
> module directories, and you have suggested a Src/Builtins directory, so
> Src/Modules is really not unique.
Just for consistency. But you are right that it would be more consistent
to use Modules everywhere and remove MODULE_DIR completely.
Zoltan
*** Src/Makefile.in 1996/12/24 01:31:03 3.1.1.2
--- Src/Makefile.in 1996/12/24 02:01:39
***************
*** 188,194 ****
modules: $(ANSI@U@KNR) $(MO@D@ULE_DIRS)
! bin: zsh
zsh: $(ANSI@U@KNR) $(@L@IBZSH) $(@L@OBJS) $(@L@STMP)
$(LINK) $(@L@OBJS) $(@L@LIST) $(LIBS)
--- 188,194 ----
modules: $(ANSI@U@KNR) $(MO@D@ULE_DIRS)
! bin: proto zsh
zsh: $(ANSI@U@KNR) $(@L@IBZSH) $(@L@OBJS) $(@L@STMP)
$(LINK) $(@L@OBJS) $(@L@LIST) $(LIBS)
***************
*** 211,217 ****
$(AWK) -f $(srcdir)/rlimits.awk $(RLIMITS_INC_H) > rlimits.h || \
echo WARNING: unknown limits: mail rlimits.h to developers
! $(OBJS): proto $(HDRS)
init.o: bltinmods.list zshpaths.h
--- 211,217 ----
$(AWK) -f $(srcdir)/rlimits.awk $(RLIMITS_INC_H) > rlimits.h || \
echo WARNING: unknown limits: mail rlimits.h to developers
! $(OBJS): $(HDRS)
init.o: bltinmods.list zshpaths.h
***************
*** 261,267 ****
$(MODBINS):
echo $(@D@YNAMIC_XMODS) > $@
! proto: $(PROTO) proto-recursive FORCE
$(PROTO): makepro.sed
--- 261,267 ----
$(MODBINS):
echo $(@D@YNAMIC_XMODS) > $@
! proto: $(PROTO) proto-recursive
$(PROTO): makepro.sed
*** Src/Zle/Makefile.in 1996/12/24 01:31:03 3.1.1.2
--- Src/Zle/Makefile.in 1996/12/24 02:00:05
***************
*** 105,116 ****
# default target
all: modules
! modules: $(MODULES)
zle.so: $(ZLEOBJS)
$(LINK) $(ZLEOBJS)
! $(OBJS): proto $(HDRS)
proto: $(PROTO)
--- 105,116 ----
# default target
all: modules
! modules: proto $(MODULES)
zle.so: $(ZLEOBJS)
$(LINK) $(ZLEOBJS)
! $(OBJS): $(HDRS)
proto: $(PROTO)
*** Src/Modules/Makefile.in 1996/12/24 01:31:03 3.1.1.2
--- Src/Modules/Makefile.in 1996/12/24 02:19:48
***************
*** 96,104 ****
# default target
all: modules
! modules: $(MODULES)
!
! $(MODULES): proto
proto: $(PROTO)
--- 96,102 ----
# default target
all: modules
! modules: proto $(MODULES)
proto: $(PROTO)
PATCH END (without this some mailers chop the last line of the patch)
next prev parent reply other threads:[~1996-12-24 3:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
1996-12-22 18:20 Zefram
1996-12-23 2:51 ` Zoltan Hidvegi
1996-12-23 20:07 ` Zefram
1996-12-24 3:01 ` Zoltan Hidvegi [this message]
1996-12-24 11:34 ` Zefram
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=199612240301.EAA02653@hzoli.ppp.cs.elte.hu \
--to=hzoli@cs.elte.hu \
--cc=zefram@dcs.warwick.ac.uk \
--cc=zsh-workers@math.gatech.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).