zsh-workers
 help / color / mirror / code / Atom feed
From: gwing@primenet.com.au
To: schaefer@nbn.com
Cc: zsh-workers@math.gatech.edu (zsh-workers)
Subject: Re: zle_refresh patch 2
Date: Tue, 4 Feb 1997 05:34:19 +1100 (EST)	[thread overview]
Message-ID: <19970203183419.24003.qmail@primenet.com.au> (raw)
In-Reply-To: <970203100507.ZM10555@candle.brasslantern.com> from "Bart Schaefer" at Feb 3, 97 10:05:07 am

Bart Schaefer wrote:
:On Feb 3,  9:55pm, gwing@primenet.com.au wrote:
:} Subject: zle_refresh patch 2
:} It fixes coredumps and bad displays when terms are 1 or 2 lines.
:} When a terminal is 1 or 2 lines high, the terminal will act as if 
:} SINGLE_LINE_ZLE is set.  This avoids many problems with the status line.
:There's already code that causes SINGLE_LINE_ZLE to become set if the
:terminal starts out at, or is shrunk to, 1 line high or 1 column wide.
:(It happens when $COLUMNS or $LINES changes.)  Some of that code is a
:few lines above your changes to test (lines < 3).

:If it's necessary to
:behave as SINGLE_LINE_ZLE for 2 lines as well, the other code should be
:changed so that SINGLE_LINE_ZLE *is* set when zsh is `acting as if' it
:is set.

I was slightly uncertain about the correct behaviour here: should
SINGLE_LINE_ZLE be set when it is `acting as if' it is set?  If it is set,
then if it stops acting as if it is set, does it go back to the previous
value?  I believe if yes to the former, then yes to the latter.  But then,
I don't necessarily believe yes to the former.

Another thing - I suggest you don't set your xterm to 2 columns or less and
setopt SINGLE_LINE_ZLE - I'll have to fix that coredump too.

I just tried your patch on my *old* source - ouch - coredump in setintenv() 
884   if ((pm = (Param) paramtab->getnode(paramtab, s)) && pm->env) {
(gdb) print paramtab
$1 = (struct hashtable *) 0x0

Hope it works OK for you.
-- 
Geoff Wing [gwing@primenet.com.au]   Technical Manager
  Phone    : +61-3-9818 2977         PrimeNet - Internet Consultancy
  Facsimile: +61-3-9819 3788         Web : <URL:http://www.primenet.com.au/>
  Mobile   : 0412 162 441


  reply	other threads:[~1997-02-03 18:39 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
1997-02-03 10:55 gwing
1997-02-03 18:05 ` Bart Schaefer
1997-02-03 18:34   ` gwing [this message]
1997-02-03 19:03     ` Bart Schaefer
1997-02-04  8:25     ` Peter Stephenson
1997-03-05 20:56   ` Zoltan T. Hidvegi
1997-03-05 21:55     ` Bart Schaefer
1997-03-05 23:06       ` Bart Schaefer
1997-03-05 23:47         ` Zoltan T. Hidvegi
1997-03-06  0:51           ` Bart Schaefer
1997-03-06  3:56             ` gwing
1997-03-06  4:58               ` Bart Schaefer
1997-03-06  5:03                 ` gwing
1997-03-06 18:32                   ` Zoltan T. Hidvegi
1997-03-06 18:58             ` Zoltan T. Hidvegi
1997-03-05 23:52 Zoltan T. Hidvegi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=19970203183419.24003.qmail@primenet.com.au \
    --to=gwing@primenet.com.au \
    --cc=schaefer@nbn.com \
    --cc=zsh-workers@math.gatech.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).