3 bugs for zsh3.0.0

3 bugs for zsh3.0.0

[Huy Le]

Hi, only tried these out HP-UX A.09.01

1) Segmentation fault on:
a="+-------------------------------------------------------+  Under
|            | HYDRO    AUTO     |    Printer | SHRED   |  Graduate
|            |                   | Stereo     | paulvig |  Computer
| MINCE                                                 |  Science
|-----------     -----------------------     -----------|
| LUST             DICE     | WRATH            PULP     |  166 Jorgensen
|                           |                           |  (Building 80)
|-----------     -----------+-----------     -----------|
| AVARICE          FRAPPE   | PRIDE            LIQUEFY  |  (818) 395-2028
|                           |                           |  Door combo: 34-12
|-----------     -----------+-----------     -----------|  Root P/W: |<R@|<
| WHIP             PUREE    | CHOP             CRUSH    |
|                           |                           |  California
|-----------     -----------+-----------     -----------|  Institute of
| GLUTTONY         BEAT     | BLEND          SLO        |  Technology  
|                           |                TH         |  1201 E. California
+-----------     -----------------------     -----------+  Pasadena, CA 91125
|                                                        
|                                                          CS Machine Room
|                                                       +  76 Jorgensen
|       HEDONO   | PHOBO         CLAUSTRO |             |  +----------+
|                |                        |             |  | OFF      |
|     -----------+-----------  -----------+-----------  |  |          |
|       ARACHNO  | AMATHO        XENO     | MYXO        |  | ENVY     |
|       technot  |                        |             |  |          |
|                                                       |  +----------+  
|       MONO     | ACRO          13       | AGORA       |
|                | liubo                  |             |
|     -----------+-----------  -----------+-----------  |
|       TAPHE    | NECRO         PHOTO    | PYRO        |
|                |                        | kkant       |
|                                                       |
+-------------------------------+=========+-------------+"
b="$a"
[[ "$a" != "$b" ]] && echo yes


2) bus error on:
local undefined
echo ${undefined#crap}


3) zsh: error on TTY read: bad file number
echo `echo \`vared -c result\` `

Re: 3 bugs for zsh3.0.0

[Peter Stephenson]

Huy Le wrote:
> 3) zsh: error on TTY read: bad file number
> echo `echo \`vared -c result\` `

I couldn't reproduce the other two but the problem here is simply that
vared only works in the top level shell where the line editor is
running but doesn't bother to test so the error message is a bit
indecipherable.

I don't think there's anything in principle stopping it from running
vared in a subshell, but the logic to do with entersubsh() and the
variables it sets would have to be changed... it's a similar problem
to `jobs' not working in a subshell even though there's no objection
in principle to listing them there.

*** Src/Zle/zle_main.c~	Tue Feb 18 09:39:53 1997
--- Src/Zle/zle_main.c	Mon Mar 10 11:12:01 1997
***************
*** 582,587 ****
--- 582,592 ----
  	args++;
      }
  
+     if (SHTTY == -1) {
+ 	zwarnnam(name, "not in interactive shell", NULL, 0);
+ 	return 1;
+     }
+ 
      /* check we have a parameter name */
      if (!*args) {
  	zwarnnam(name, "missing variable", NULL, 0);



-- 
Peter Stephenson <pws@ifh.de>       Tel: +49 33762 77366
WWW:  http://www.ifh.de/~pws/       Fax: +49 33762 77413
Deutsches Elektronen-Synchrotron --- Institut fuer Hochenergiephysik Zeuthen
DESY-IfH, 15735 Zeuthen, Germany.

Re: 3 bugs for zsh3.0.0

[Zefram]

-----BEGIN PGP SIGNED MESSAGE-----

>2) bus error on:
>local undefined
>echo ${undefined#crap}

The parameter code, when asked for the value of an undefined parameter,
is returning a constant empty string.  The glob code assumes that it can
write into any parameter value.  The real solution would be to stop the
glob code writing into strings that it shouldn't modify, and I'd like
to do this as part of making zsh const-correct.  But for the moment it
will suffice to make the parameter code return an allocated empty string,
as it already does in some cases.

 -zefram

      *** Src/params.c	1997/03/17 00:38:10	1.36
      --- Src/params.c	1997/03/17 13:16:13
      ***************
      *** 677,685 ****
            char *s, **ss;
            static char buf[(SIZEOF_LONG * 8) + 4];
        
      -     if (!v)
      - 	return "";
            HEAPALLOC {
        	if (v->inv) {
        	    sprintf(buf, "%d", v->a);
        	    s = dupstring(buf);
      --- 677,685 ----
            char *s, **ss;
            static char buf[(SIZEOF_LONG * 8) + 4];
        
            HEAPALLOC {
      + 	if (!v)
      + 	    return dupstring("");
        	if (v->inv) {
        	    sprintf(buf, "%d", v->a);
        	    s = dupstring(buf);
      ***************
      *** 694,700 ****
        		ss = v->pm->gets.afn(v->pm);
        		if (v->a < 0)
        		    v->a += arrlen(ss);
      ! 		s = (v->a >= arrlen(ss) || v->a < 0) ? "" : ss[v->a];
        	    }
        	    LASTALLOC_RETURN s;
        	case PM_INTEGER:
      --- 694,700 ----
        		ss = v->pm->gets.afn(v->pm);
        		if (v->a < 0)
        		    v->a += arrlen(ss);
      ! 		s = (v->a >= arrlen(ss) || v->a < 0) ? dupstring("") : ss[v->a];
        	    }
        	    LASTALLOC_RETURN s;
        	case PM_INTEGER:
      ***************
      *** 1188,1194 ****
        char *
        strgetfn(Param pm)
        {
      !     return pm->u.str ? pm->u.str : "";
        }
        
        /* Function to set value of a scalar (string) parameter */
      --- 1188,1194 ----
        char *
        strgetfn(Param pm)
        {
      !     return pm->u.str ? pm->u.str : hcalloc(1);
        }
        
        /* Function to set value of a scalar (string) parameter */
      ***************
      *** 1314,1320 ****
            char *s = *((char **)pm->data);
        
            if (!s)
      ! 	return "";
            return s;
        }
        
      --- 1314,1320 ----
            char *s = *((char **)pm->data);
        
            if (!s)
      ! 	return hcalloc(1);
            return s;
        }
        

-----BEGIN PGP SIGNATURE-----
Version: 2.6.3ia
Charset: ascii

iQCVAwUBMy1FZXD/+HJTpU/hAQE5kQP/aYmYQVr7bUhFhdjissNyzeFn1Bb6DpYG
Hs7X+VpQut8RkqoKXhe9Dqy3DW2xr1DhW9anNhOHkYf5Aqo0KhlNuB1stPrpi/tT
4pLIjxZUuGhQv3XShafyaxJoxGwWSnfXgBNa47zNVvsJAfMGs7UD+FR0KBAc7PXl
uPehnmaqnHg=
=ooJu
-----END PGP SIGNATURE-----