zsh-workers
 help / color / mirror / code / Atom feed
* compctl -X
@ 1997-08-04 16:35 Peter Stephenson
  1997-08-05  6:47 ` Zoltan Hidvegi
  0 siblings, 1 reply; 4+ messages in thread
From: Peter Stephenson @ 1997-08-04 16:35 UTC (permalink / raw)
  To: Zsh hackers list

I sent this some time ago, it seems to have disappeared...

`compctl -X explanation' should print the explanation if there *are*
matching completions, not if there aren't.  If the type of matching
wasn't used, you don't care; if it was, you want to know why.

*** Src/Zle/zle_tricky.c.minusX	Mon Jul 14 11:44:47 1997
--- Src/Zle/zle_tricky.c	Fri Aug  1 14:16:33 1997
***************
*** 2128,2134 ****
  	}
  
  	/* Print the explanation string if needed. */
! 	if (!showinglist && expl && !nmatches) {
  	    int up;
  
  	    feep();
--- 2128,2134 ----
  	}
  
  	/* Print the explanation string if needed. */
! 	if (!showinglist && expl && nmatches) {
  	    int up;
  
  	    feep();

-- 
Peter Stephenson <pws@ifh.de>       Tel: +49 33762 77366
WWW:  http://www.ifh.de/~pws/       Fax: +49 33762 77413
Deutsches Elektronen-Synchrotron --- Institut fuer Hochenergiephysik Zeuthen
DESY-IfH, Platanenallee 6, 15738 Zeuthen, Germany.


^ permalink raw reply	[flat|nested] 4+ messages in thread
* compctl -X
@ 1997-02-19 15:57 Peter Stephenson
  0 siblings, 0 replies; 4+ messages in thread
From: Peter Stephenson @ 1997-02-19 15:57 UTC (permalink / raw)
  To: Zsh hackers list

Zoltan fixed compctl -X some time ago, but I think there's still
something wrong:  it works when listing but when actually completing
it prints the explanation only if the completion failed --- surely it
should print it only if the completion succeded?  You don't want to
be told `Doing completion X, 0 matches' when the completion mechanism
is trying something else, you want to be told when it *has* found
something according to that rule and is therefore inserting the
result.  (I should have woken up to this earlier, sorry.)

*** Src/Zle/zle_tricky.c.expl	Wed Feb 19 16:37:40 1997
--- Src/Zle/zle_tricky.c	Wed Feb 19 16:37:47 1997
***************
*** 2123,2129 ****
  	}
  
  	/* Print the explanation string if needed. */
! 	if (!showinglist && expl && !nmatches) {
  	    int up;
  
  	    feep();
--- 2123,2129 ----
  	}
  
  	/* Print the explanation string if needed. */
! 	if (!showinglist && expl && nmatches) {
  	    int up;
  
  	    feep();

-- 
Peter Stephenson <pws@ifh.de>       Tel: +49 33762 77366
WWW:  http://www.ifh.de/~pws/       Fax: +49 33762 77413
Deutsches Elektronen-Synchrotron --- Institut fuer Hochenergiephysik Zeuthen
DESY-IfH, 15735 Zeuthen, Germany.


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~1997-08-05  8:09 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
1997-08-04 16:35 compctl -X Peter Stephenson
1997-08-05  6:47 ` Zoltan Hidvegi
1997-08-05  7:52   ` Peter Stephenson
  -- strict thread matches above, loose matches on Subject: below --
1997-02-19 15:57 Peter Stephenson

Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).