zsh-workers
 help / color / mirror / code / Atom feed
* Re: Zle bug
       [not found] <aheading@jpmorgan.com>
@ 1998-02-09 13:23 ` Wez Furlong
  1998-04-28 12:34   ` up-line-or-search still 'fixed'! Anthony Heading
  0 siblings, 1 reply; 21+ messages in thread
From: Wez Furlong @ 1998-02-09 13:23 UTC (permalink / raw)
  To: zsh-workers

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1250 bytes --]

On Feb 9, 12:57pm, Anthony JR Heading wrote:

: On Sun, Feb 01, 1998 at 03:41:48PM +0100, Thomas Köhler wrote:
: > I'd say "no, it's a bug" ;-)
: > Looking at the manpages, I found this:
: > 
: >           up-line-or-search
: >           Move  up a line in the buffer, or if already at the
: >           top line, search backward in the history for a line
: >           beginning with the first word in the buffer.
: 
: Wouldn't it be preferable to fix the documentation rather than
: the code?  I've also used this feature for as long as I can recall,
: and FWIW the new behaviour I also assumed to be a bug.

: Seriously, if you have this function bound the cursor keys, this is
: a major breakage.

After trying to use the other suggestion, I have to agree - can we fix
the documentation and adjust the code so that the behaviour is the same
as 3.0.5? I can't see the way to getting the widget to work for this
function anyway.


-- 
Wez Furlong                        Undergrad - Electronic Systems Engineering
                                           http://www.twinklestar.demon.co.uk
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


^ permalink raw reply	[flat|nested] 21+ messages in thread

* up-line-or-search still 'fixed'!
  1998-02-09 13:23 ` Zle bug Wez Furlong
@ 1998-04-28 12:34   ` Anthony Heading
  1998-04-28 13:21     ` Andy Wick
  1998-04-28 13:33     ` Anthony Heading
  0 siblings, 2 replies; 21+ messages in thread
From: Anthony Heading @ 1998-04-28 12:34 UTC (permalink / raw)
  To: zsh-workers

We had the following discussion a couple of months back.  Zefram, can you please comment.

Anthony

On Mon, Feb 09, 1998 at 01:23:55PM +0000, Wez Furlong wrote:
> On Feb 9, 12:57pm, Anthony JR Heading wrote:
> 
> : On Sun, Feb 01, 1998 at 03:41:48PM +0100, Thomas Köhler wrote:
> : > I'd say "no, it's a bug" ;-)
> : > Looking at the manpages, I found this:
> : > 
> : >           up-line-or-search
> : >           Move  up a line in the buffer, or if already at the
> : >           top line, search backward in the history for a line
> : >           beginning with the first word in the buffer.
> : 
> : Wouldn't it be preferable to fix the documentation rather than
> : the code?  I've also used this feature for as long as I can recall,
> : and FWIW the new behaviour I also assumed to be a bug.
> 
> : Seriously, if you have this function bound the cursor keys, this is
> : a major breakage.
> 
> After trying to use the other suggestion, I have to agree - can we fix
> the documentation and adjust the code so that the behaviour is the same
> as 3.0.5? I can't see the way to getting the widget to work for this
> function anyway.

-- 
Anthony J.R. Heading    J.P. Morgan Securities Ltd, London
Email: heading_anthony@jpmorgan.com  Tel: +44 171 325 5962


^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: up-line-or-search still 'fixed'!
  1998-04-28 12:34   ` up-line-or-search still 'fixed'! Anthony Heading
@ 1998-04-28 13:21     ` Andy Wick
  1998-04-28 13:33     ` Anthony Heading
  1 sibling, 0 replies; 21+ messages in thread
From: Andy Wick @ 1998-04-28 13:21 UTC (permalink / raw)
  To: zsh-workers


I sent a message a while back that up-line-or-search DOESN'T work AT ALL
on many platforms with zsh-3.1.2-zefram4, up-line-or-history DOES
work when bound to the arrow keys.  Can anyone get up-line-or-search to work 
with zefram4?

Thanks,
Andy

On Tue, Apr 28, 1998 at 01:34:46PM +0100, Anthony Heading wrote:
> We had the following discussion a couple of months back.  Zefram, can you please comment.
> 
> Anthony
> 
> On Mon, Feb 09, 1998 at 01:23:55PM +0000, Wez Furlong wrote:
> > On Feb 9, 12:57pm, Anthony JR Heading wrote:
> > 
> > : On Sun, Feb 01, 1998 at 03:41:48PM +0100, Thomas Kvhler wrote:
> > : > I'd say "no, it's a bug" ;-)
> > : > Looking at the manpages, I found this:
> > : > 
> > : >           up-line-or-search
> > : >           Move  up a line in the buffer, or if already at the
> > : >           top line, search backward in the history for a line
> > : >           beginning with the first word in the buffer.
> > : 
> > : Wouldn't it be preferable to fix the documentation rather than
> > : the code?  I've also used this feature for as long as I can recall,
> > : and FWIW the new behaviour I also assumed to be a bug.
> > 
> > : Seriously, if you have this function bound the cursor keys, this is
> > : a major breakage.
> > 
> > After trying to use the other suggestion, I have to agree - can we fix
> > the documentation and adjust the code so that the behaviour is the same
> > as 3.0.5? I can't see the way to getting the widget to work for this
> > function anyway.
> 
> -- 
> Anthony J.R. Heading    J.P. Morgan Securities Ltd, London
> Email: heading_anthony@jpmorgan.com  Tel: +44 171 325 5962
> 

-- 
awick@vt.edu                                    Andy Wick
awick@purple.org                              Virginia Tech


^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: up-line-or-search still 'fixed'!
  1998-04-28 12:34   ` up-line-or-search still 'fixed'! Anthony Heading
  1998-04-28 13:21     ` Andy Wick
@ 1998-04-28 13:33     ` Anthony Heading
  1998-04-28 14:08       ` Andrew Main
  1 sibling, 1 reply; 21+ messages in thread
From: Anthony Heading @ 1998-04-28 13:33 UTC (permalink / raw)
  To: zsh-workers

On Tue, Apr 28, 1998 at 01:34:46PM +0100, I wrote:
> We had the following discussion a couple of months back.  Zefram, can you please comment.

Sorry to follow up my own email (though I realize my sig needed to be updated).
Am just trying to patch in the old behaviour, and realizing it's quite involved -
ZLE_HISTSEARCH has been excised, and histpos is no longer a static variable,
so there's no record of how far through a word the search should be keyed from.

I'm willing to write a patch to add this all back again if it would help, but
there's not much point unless there's a desire to maintain this functionality.
Why was it so totally removed?

A

-- 
Anthony J.R. Heading    J.P. Morgan & Co. Inc, Singapore
Email: heading_anthony@jpmorgan.com    Tel: +65 326 9027


^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: up-line-or-search still 'fixed'!
  1998-04-28 13:33     ` Anthony Heading
@ 1998-04-28 14:08       ` Andrew Main
  1998-06-09 13:13         ` Anthony Heading
  0 siblings, 1 reply; 21+ messages in thread
From: Andrew Main @ 1998-04-28 14:08 UTC (permalink / raw)
  To: Anthony Heading; +Cc: zsh-workers

Anthony Heading wrote:
>ZLE_HISTSEARCH has been excised, and histpos is no longer a static variable,
>so there's no record of how far through a word the search should be keyed from.

Yes.  That's why I'm unwilling to go back to the old behaviour.
The behaviour of up-line-or-search used to depend on whether the
immediately preceding editing command was also up-line-or-search.
The model I'm trying to move ZLE to has the effects of each editing
command as independent as possible of other commands, so that eventually
most of them can be separated into modules or even implemented purely
as shell functions.  Each of the ZLE_* flags violates this principle to
some extent, so I'm trying to remove them as far as possible (which will
not be completely).

I've been considering other ways of recording the bits of state that the
ZLE_* flags and various static variables contain.  I'd like everything to
be user-accessible, for widgets.  In a future version it will definitely
be possible to implement the old up-line-or-search, if one really wants
to.  But for the moment it just doesn't fit into the ZLE architecture.

How would people feel about making up-line-or-search do a
history-beginning-search-backwards?  This would be a lot closer to the
old behaviour, differing only in the resulting cursor position.

-zefram


^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: up-line-or-search still 'fixed'!
  1998-04-28 14:08       ` Andrew Main
@ 1998-06-09 13:13         ` Anthony Heading
  1998-06-09 15:22           ` Bart Schaefer
  0 siblings, 1 reply; 21+ messages in thread
From: Anthony Heading @ 1998-06-09 13:13 UTC (permalink / raw)
  To: Andrew Main; +Cc: Anthony Heading, zsh-workers

On Tue, Apr 28, 1998 at 03:08:04PM +0100, Andrew Main wrote:
> Yes.  That's why I'm unwilling to go back to the old behaviour.
> The behaviour of up-line-or-search used to depend on whether the
> immediately preceding editing command was also up-line-or-search.
> The model I'm trying to move ZLE to has the effects of each editing
> command as independent as possible of other commands, so that eventually
> most of them can be separated into modules or even implemented purely
> as shell functions.  Each of the ZLE_* flags violates this principle to
> some extent, so I'm trying to remove them as far as possible (which will
> not be completely).
[...] 
> But for the moment it just doesn't fit into the ZLE architecture.
> 
> How would people feel about making up-line-or-search do a
> history-beginning-search-backwards?  This would be a lot closer to the
> old behaviour, differing only in the resulting cursor position.

OK.  I've done my best to live with this for six weeks.  But it just isn't
working for me.   This was a really major feature for anyone who had it
turned on, and having read the code now, IMHO the hit far outweighed the
benefits of a fractionally less broken architecture:  it was doing no real
harm until it was the last of the residual state variables.

So I really must protest.  This is purism over usability!

Thus unfortunately, I'm going to have to switch back to 3.0.5 until
the brave new dawn.  

-- 
Anthony J.R. Heading    J.P. Morgan & Co. Inc, Singapore
Email: heading_anthony@jpmorgan.com    Tel: +65 326 9027


^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: up-line-or-search still 'fixed'!
  1998-06-09 13:13         ` Anthony Heading
@ 1998-06-09 15:22           ` Bart Schaefer
  1998-06-09 15:50             ` Bruce Stephens
  1998-06-10  5:18             ` message numbers in mla Geoff Wing
  0 siblings, 2 replies; 21+ messages in thread
From: Bart Schaefer @ 1998-06-09 15:22 UTC (permalink / raw)
  To: Andrew Main, zsh-workers; +Cc: Anthony Heading

On Jun 9,  2:13pm, Anthony Heading wrote:
} Subject: Re: up-line-or-search still 'fixed'!
}
} On Tue, Apr 28, 1998 at 03:08:04PM +0100, Andrew Main wrote:
} > Yes.  That's why I'm unwilling to go back to the old behaviour.
} > The behaviour of up-line-or-search used to depend on whether the
} > immediately preceding editing command was also up-line-or-search.
} > The model I'm trying to move ZLE to has the effects of each editing
} > command as independent as possible of other commands
} > 
} > How would people feel about making up-line-or-search do a
} > history-beginning-search-backwards?  This would be a lot closer to the
} > old behaviour, differing only in the resulting cursor position.
} 
} OK.  I've done my best to live with this for six weeks.  But it just isn't
} working for me.   This was a really major feature for anyone who had it
} turned on, and having read the code now, IMHO the hit far outweighed the
} benefits of a fractionally less broken architecture:  it was doing no real
} harm until it was the last of the residual state variables.

If this were the IETF (which thank goodness it isn't, but) we'd take a
straw poll at this point.  So far I'm "hearing" a lot of protest about
this change from actual users of the shell and support only from those
interested in internal architecture.  Are we writing usable software or
carrying on an academic excercise?

Making editing commands independent of each other is impossible anyway.
They have to share the text buffer, the cursor position, the cut buffer,
all the vi named registers, etc. etc.  Eliminating shared data is the
wrong approach; consolidating shared data into an "editor state" object
is the way to go.

It is true that remembering a position in the line and keying the search
from there was never the "right" thing to do.  The actual string to search
for should be saved somewhere and re-used.  If we were following the emacs
model, there'd be a repeat-history-search-*ward that called up that string
and searched again for it, and invoking history-search-*ward would install
a new keymap where the keys used to begin searching are bound to repeat-*
and the other keys install the old keymap and then re-interpret themselves.

Regardless of how it's implemented, that is the way this should *behave*.
The claim that searching for the whole first word is "more like the
documentation says" is nothing more than a rationalization for breakage,
and is still imperfect if implementation purity is what you're after.

(The two patches that originally introduced this change can be found at

http://www.zsh.org/mla/workers-1997-hyper/0030.html
http://www.zsh.org/mla/workers-1997-hyper/0039.html

Hey, there, mailing-list-archive maintainer, how's about including the
X-Mailing-List header somewhere in what's visible and searchable, so
that the patch numbers in the ChangeLog can be used to hunt this stuff
down?)

-- 
Bart Schaefer                                 Brass Lantern Enterprises
http://www.well.com/user/barts              http://www.brasslantern.com


^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: up-line-or-search still 'fixed'!
  1998-06-09 15:22           ` Bart Schaefer
@ 1998-06-09 15:50             ` Bruce Stephens
  1998-06-09 18:42               ` Bart Schaefer
  1998-06-10  5:18             ` message numbers in mla Geoff Wing
  1 sibling, 1 reply; 21+ messages in thread
From: Bruce Stephens @ 1998-06-09 15:50 UTC (permalink / raw)
  To: zsh-workers

"Bart Schaefer" <schaefer@brasslantern.com> writes:

> If this were the IETF (which thank goodness it isn't, but) we'd take
> a straw poll at this point.  So far I'm "hearing" a lot of protest
> about this change from actual users of the shell and support only
> from those interested in internal architecture.  Are we writing
> usable software or carrying on an academic excercise?

The former, but people are also aiming for internal beauty and
simplicity, I think.  (Well, maybe it's more "practical
maintainability" than "simplicity".)

Maybe somebody could summarise the specific question?  I've not
noticed any particular change recently: the last change that irritated
me a bit was the */ becoming *(/), which I understand was necessary,
but I used */ quite a bit.

Maybe if the interface that's changed was described concisely,
together with the reasons for changing it, then it would be obvious to
people that it was worth keeping, or some workaround would become
clearer?


^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: up-line-or-search still 'fixed'!
  1998-06-09 15:50             ` Bruce Stephens
@ 1998-06-09 18:42               ` Bart Schaefer
  1998-06-10 10:14                 ` Bruce Stephens
  0 siblings, 1 reply; 21+ messages in thread
From: Bart Schaefer @ 1998-06-09 18:42 UTC (permalink / raw)
  To: Bruce Stephens, zsh-workers

On Jun 9,  4:50pm, Bruce Stephens wrote:
} Subject: Re: up-line-or-search still 'fixed'!
}
} "Bart Schaefer" <schaefer@brasslantern.com> writes:
} 
} > If this were the IETF (which thank goodness it isn't, but) we'd take
} > a straw poll at this point.  So far I'm "hearing" a lot of protest
} > about this change from actual users of the shell and support only
} > from those interested in internal architecture.
} 
} Maybe somebody could summarise the specific question?

The question is, why did the behavior of up-line-or-search (and down-*)
change from zsh 3.0.x to zsh 3.1.x?

The answer is the same as the answer to the question, why did the behavior
of history-search-backward (and *-forward) change?

This isn't a "recent" change -- it took place in January 1997 -- but there
are several of us who've been protesting it all along.  It's come to a head
now because 3.0.5 now seems to really and truly be the final 3.0 release,
so soon there will be development/bugfixes only on 3.1.  If we're going to
continue using 3.1 and beyond, we need to resolve this issue.

} Maybe if the interface that's changed was described concisely,
} together with the reasons for changing it, then it would be obvious to
} people that it was worth keeping, or some workaround would become
} clearer?

It's pretty simple, really.

The 3.0 and earlier, history-search-*ward would record the length of the
search pattern and remember that the command was search.  When a second
history-search-*ward immediately followed, the current line up to the old
pattern length would be read and used as the search pattern.  Otherwise,
the current line up to the current cursor position -or- the end of the
first word (whichever came first) was read and used as the search pattern.
(Now loop back to the top of this paragraph.)

When user-defined widgets were introduced, the "old pattern length" or the
state of "was the last command a search" could become incorrect (that is,
things could change without the zle internals finding out all the details).
This meant that repeated backward searches could fail in unexpected ways.
To fix this, Zefram made two changes to history-search-*ward:  (1) they
ignore the cursor position and the previous pattern length, and (2) they
always search for an entire word matching the first entire word on the
current command line.

It's behavior (2) that we object to.  Those of us who use *-line-or-search,
which are implemented by calling history-search-*ward, were used to having
a *partial* word at the beginning of the current line matched against the
history.  It's significantly less useful if you must type the entire first
word before beginning the search.

We could reimplement *-line-or-search with history-beginning-search-*ward,
but there are two drawbacks to that:  (A) they won't stop reading the
pattern after the first word, they always read all the way to the cursor
position; (B) they won't reposition the cursor to the end of the line,
which history-search-*ward do (and can't, because the cursor position has
to remain unchanged for the next search to work correctly).  (A) is the
biggest problem.

It's my assertion that history-search-*ward are now broken and should be
made to behave the way they used to (but not implemented the way they
used to be implemented).  That fixes *-line-or-search as a side-effect.
It might be possible to fix *-line-or-search independently, but IMO that
is glossing over the underlying brokenness of history-search-*ward.

-- 
Bart Schaefer                                 Brass Lantern Enterprises
http://www.well.com/user/barts              http://www.brasslantern.com


^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: message numbers in mla
  1998-06-09 15:22           ` Bart Schaefer
  1998-06-09 15:50             ` Bruce Stephens
@ 1998-06-10  5:18             ` Geoff Wing
  1998-06-22 11:16               ` Geoff Wing
  1 sibling, 1 reply; 21+ messages in thread
From: Geoff Wing @ 1998-06-10  5:18 UTC (permalink / raw)
  To: zsh-workers

Bart Schaefer <schaefer@brasslantern.com> typed:
:http://www.zsh.org/mla/workers-1997-hyper/0030.html
:http://www.zsh.org/mla/workers-1997-hyper/0039.html
:Hey, there, mailing-list-archive maintainer, how's about including the
:X-Mailing-List header somewhere in what's visible and searchable, so
:that the patch numbers in the ChangeLog can be used to hunt this stuff
:down?)

Yes, well, unfortunately I set it up with (a minorly hacked version of)
hypermail which is somewhat limited.  I had planned to write my own simple
one or maybe switch to one that does keep specific headers (mhonarc?) but
there are many things I didn't like (when I last looked 1 - 1 1/2 years ago)
about all of the existing ones anyway.  As for writing my own, well, time is
available to me only for short periods at the moment.
-- 
Geoff Wing   <gcw@pobox.com>            Mobile : 0412 162 441
Work URL: http://www.primenet.com.au/   Ego URL: http://pobox.com/~gcw/


^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: up-line-or-search still 'fixed'!
  1998-06-09 18:42               ` Bart Schaefer
@ 1998-06-10 10:14                 ` Bruce Stephens
  1998-06-10 10:31                   ` Zefram
  0 siblings, 1 reply; 21+ messages in thread
From: Bruce Stephens @ 1998-06-10 10:14 UTC (permalink / raw)
  To: zsh-workers

"Bart Schaefer" <schaefer@brasslantern.com> writes:

> The question is, why did the behavior of up-line-or-search (and down-*)
> change from zsh 3.0.x to zsh 3.1.x?
> 
> The answer is the same as the answer to the question, why did the behavior
> of history-search-backward (and *-forward) change?

Ah, that would explain why I'm sometimes surprised by what M-p
produces.  You're right, it's broken; I just hadn't really noticed
properly and found out what was broken.

If I type "ls foo<M-p>", I'm clearly looking for a line beginning with
"ls foo", not one beginning with "ls".

As you say, one solution would be a special mode, like the incremental
modes, which would remember what they were looking for. 

Another one---which I think I'd find acceptable---would be not to move
the cursor, so history-search-backward would always search for the
text before the cursor.  Or has that been tried, and people hated it?


^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: up-line-or-search still 'fixed'!
  1998-06-10 10:14                 ` Bruce Stephens
@ 1998-06-10 10:31                   ` Zefram
  1998-06-10 11:57                     ` Bruce Stephens
  0 siblings, 1 reply; 21+ messages in thread
From: Zefram @ 1998-06-10 10:31 UTC (permalink / raw)
  To: Bruce Stephens; +Cc: zsh-workers

Bruce Stephens wrote:
>Another one---which I think I'd find acceptable---would be not to move
>the cursor, so history-search-backward would always search for the
>text before the cursor.  Or has that been tried, and people hated it?

That's exactly what history-beginning-search-* do.

-zefram


^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: up-line-or-search still 'fixed'!
  1998-06-10 10:31                   ` Zefram
@ 1998-06-10 11:57                     ` Bruce Stephens
  1998-06-10 17:13                       ` Bart Schaefer
  0 siblings, 1 reply; 21+ messages in thread
From: Bruce Stephens @ 1998-06-10 11:57 UTC (permalink / raw)
  To: zsh-workers

Zefram <zefram@tao.co.uk> writes:

> Bruce Stephens wrote:
> >Another one---which I think I'd find acceptable---would be not to move
> >the cursor, so history-search-backward would always search for the
> >text before the cursor.  Or has that been tried, and people hated it?
> 
> That's exactly what history-beginning-search-* do.

Doh.  And it's even what M-p, M-n are bound to.  So is the problem
that people really like(d) the behaviour of going to the end of the
line?


^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: up-line-or-search still 'fixed'!
  1998-06-10 11:57                     ` Bruce Stephens
@ 1998-06-10 17:13                       ` Bart Schaefer
  0 siblings, 0 replies; 21+ messages in thread
From: Bart Schaefer @ 1998-06-10 17:13 UTC (permalink / raw)
  To: Bruce Stephens, zsh-workers, Zefram

On Jun 10, 12:57pm, Bruce Stephens wrote:
} Subject: Re: up-line-or-search still 'fixed'!
}
} Zefram <zefram@tao.co.uk> writes:
} 
} > Bruce Stephens wrote:
} > >Another one---which I think I'd find acceptable---would be not to move
} > >the cursor, so history-search-backward would always search for the
} > >text before the cursor.  Or has that been tried, and people hated it?
} > 
} > That's exactly what history-beginning-search-* do.
} 
} Doh.  And it's even what M-p, M-n are bound to.  So is the problem
} that people really like(d) the behaviour of going to the end of the
} line?

No; I explained what the problems are:

(1) history-search-*ward now match only complete words; they used to
    match prefixes of words too.
(2) history-beginning-search-*ward match across word boundaries; the
    desired behavior is to stop matching at the first word boundary
    (or before, see (1)).
(3) *-line-or-search, what we really want to use, are affected by the
    implementation of history-search-*ward.

The thing with the cursor moving to the end of the line is simply there
to "look like emacs".  (In emacs shell mode, if you hit return with the
cursor in the middle of the line, it acts like zsh's accept-and-hold, but
if you hit return at the end of the line it acts like accept-line.  So
history searches in emacs always place the cursor at end of the line, and
Paul F. made zsh act the same.)

-- 
Bart Schaefer                                 Brass Lantern Enterprises
http://www.well.com/user/barts              http://www.brasslantern.com


^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: message numbers in mla
  1998-06-10  5:18             ` message numbers in mla Geoff Wing
@ 1998-06-22 11:16               ` Geoff Wing
  1998-06-22 16:17                 ` Bart Schaefer
  0 siblings, 1 reply; 21+ messages in thread
From: Geoff Wing @ 1998-06-22 11:16 UTC (permalink / raw)
  To: zsh-workers

Geoff Wing <mason@primenet.com.au> typed:
:Bart Schaefer <schaefer@brasslantern.com> typed:
::http://www.zsh.org/mla/workers-1997-hyper/0030.html
::http://www.zsh.org/mla/workers-1997-hyper/0039.html
::Hey, there, mailing-list-archive maintainer, how's about including the
::X-Mailing-List header somewhere in what's visible and searchable, so
::that the patch numbers in the ChangeLog can be used to hunt this stuff
::down?)
:Yes, well, unfortunately I set it up with (a minorly hacked version of)
:hypermail which is somewhat limited.  I had planned to write my own simple
:one or maybe switch to one that does keep specific headers (mhonarc?) but
:there are many things I didn't like (when I last looked 1 - 1 1/2 years ago)
:about all of the existing ones anyway.  As for writing my own, well, time is
:available to me only for short periods at the moment.

Heyla,
I've just reprocessed all the current mailing list archive (1995 - now) with
Mhonarc.  There are a couple of changes I will probably make when I get some
more time: forward/backward date/thread links per message; properly 
searchable; etc.

The X-Mailing-List header is preserved in each final message which contains
the official archive number as indexed by the mailing list distributer (and
allows retrieving of non-HTML'd versions from either math.gatech.edu or 
http://www.zsh.org/mla/zsh-{users,workers})

All references to .../mla/*-hyper/ are now invalid ('cos I've deleted it all). 
Hope this is useful to people.
-- 
Geoff Wing   <gcw@pobox.com>            Mobile : 0412 162 441
Work URL: http://www.primenet.com.au/   Ego URL: http://pobox.com/~gcw/


^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: message numbers in mla
  1998-06-22 11:16               ` Geoff Wing
@ 1998-06-22 16:17                 ` Bart Schaefer
  1998-06-22 17:38                   ` Richard Coleman
  0 siblings, 1 reply; 21+ messages in thread
From: Bart Schaefer @ 1998-06-22 16:17 UTC (permalink / raw)
  To: zsh-workers

On Jun 22, 11:16am, Geoff Wing wrote:
} Subject: Re: message numbers in mla
}
} All references to .../mla/*-hyper/ are now invalid ('cos I've deleted it
} all).

This is the sort of thing that should be mentioned on the web page, at
least temporarily, and announced on zsh-announce.  (Who is the official
announce person now?  Zefram?)

-- 
Bart Schaefer                                 Brass Lantern Enterprises
http://www.well.com/user/barts              http://www.brasslantern.com


^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: message numbers in mla
  1998-06-22 16:17                 ` Bart Schaefer
@ 1998-06-22 17:38                   ` Richard Coleman
  0 siblings, 0 replies; 21+ messages in thread
From: Richard Coleman @ 1998-06-22 17:38 UTC (permalink / raw)
  To: zsh-workers

> } All references to .../mla/*-hyper/ are now invalid ('cos I've deleted it
> } all).
> 
> This is the sort of thing that should be mentioned on the web page, at
> least temporarily, and announced on zsh-announce.  (Who is the official
> announce person now?  Zefram?)

Zefram, Peter, and myself can post to zsh-announce.

--
Richard Coleman
coleman@math.gatech.edu


^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: Zle bug
  1998-02-01 14:41 ` Thomas Köhler
@ 1998-02-09 12:57   ` Anthony JR Heading
  0 siblings, 0 replies; 21+ messages in thread
From: Anthony JR Heading @ 1998-02-09 12:57 UTC (permalink / raw)
  To: Thomas Köhler; +Cc: zsh-workers, wez

On Sun, Feb 01, 1998 at 03:41:48PM +0100, Thomas Köhler wrote:
> 
> I'd say "no, it's a bug" ;-)
> Looking at the manpages, I found this:
> 
>           up-line-or-search
>           Move  up a line in the buffer, or if already at the
>           top line, search backward in the history for a line
>           beginning with the first word in the buffer.
> 

Wouldn't it be preferable to fix the documentation rather than
the code?  I've also used this feature for as long as I can recall,
and FWIW the new behaviour I also assumed to be a bug.

Long live the status quo!  Down with user-defined widgets!  Affirmative
action for non-word-boundaries!

Seriously, if you have this function bound the cursor keys, this is
a major breakage.

Anthony


^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: Zle bug
@ 1998-02-02  2:58 Wez Furlong
  0 siblings, 0 replies; 21+ messages in thread
From: Wez Furlong @ 1998-02-02  2:58 UTC (permalink / raw)
  To: Thomas Köhler; +Cc: zsh-workers

On Feb 1,  3:41pm, =?iso-8859-1?Q?Thomas_K=F6hler?= wrote:
> On Feb 1, Wez Furlong wrote
> > I am reporting a bug that is present in zsh 3.1.2 and also 3.1.2-zefram3.
> > Here's a demonstration:
> > 
> > % > bindkey  '\e[A'   up-line-or-search
> > % > w
> > At this point I press cursor up
> > % > who
> > This is correct.

> I'd say "no, it's a bug" ;-)

> Looking at the manpages, I found this:
> 
>           up-line-or-search
>           Move  up a line in the buffer, or if already at the
>           top line, search backward in the history for a line
>           beginning with the first word in the buffer.

> Perhaps this can't be done in zsh-3.1.2 as it is now, we may need
> something like "up-line-or-history-beginning-search-backward". ;-)
[much snipping applied]

Hmm. I suppose you are right. I shall be changing to
history-beginning-search-backward (I don't often use multi-line editing).

The "up-line-or-history-beginning-search-backward" would be nice idea though.
__
Wez Furlong                        Undergrad - Electronic Systems Engineering
                                           http://www.twinklestar.demon.co.uk
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: Zle bug
  1998-02-01  3:16 Wez Furlong
@ 1998-02-01 14:41 ` Thomas Köhler
  1998-02-09 12:57   ` Anthony JR Heading
  0 siblings, 1 reply; 21+ messages in thread
From: Thomas Köhler @ 1998-02-01 14:41 UTC (permalink / raw)
  To: zsh-workers; +Cc: wez

On Feb 1, Wez Furlong wrote

> Hi,
> 
> I am reporting a bug that is present in zsh 3.1.2 and also 3.1.2-zefram3.
> I have mentioned it before (when 3.1.2 was first released) but it does not
> appear to have been addressed.
> 
> Here's a demonstration:
> 
> % > zsh -f
> % > echo $ZSH_VERSION
> 3.0.5
> % > bindkey  '\e[A'   up-line-or-search
> % > who
> wez      tty3     Feb  1 00:37
> root     tty4     Feb  1 00:42
> root     tty2     Jan 31 16:51
> wez      tty5     Feb  1 01:42
> % > ls
> Admin              Personal           UNI                root
> Amiga              Povray             Wez-Crontab        spambounce.tar.gz
> Dave               Src                mail.vim           tmp
> PCMCIA             Stuff              mbox
> % > w
> 
> At this point I press cursor up
> 
> % > who
> 
> This is correct.

I'd say "no, it's a bug" ;-)

> And here is the bug, with 3.1.2:
> 
> % > zsh -f
> % > echo $ZSH_VERSION
> 3.1.2
> % > bindkey  '\e[A'   up-line-or-search
> % > who
> wez      tty3     Feb  1 00:37
> root     tty4     Feb  1 00:42
> root     tty2     Jan 31 16:51
> wez      tty5     Feb  1 01:42
> % > ls
> Admin              Personal           UNI                root
> Amiga              Povray             Wez-Crontab        spambounce.tar.gz
> Dave               Src                mail.vim           tmp
> PCMCIA             Stuff              mbox
> % > w
> 
> Pressing cursor up produces a beep.
> 
> % > w

Looking at the manpages, I found this:

          up-line-or-search
          Move  up a line in the buffer, or if already at the
          top line, search backward in the history for a line
          beginning with the first word in the buffer.

It works like this:
~> zsh -f
% echo $ZSH_VERSION
3.1.2
% bindkey '\e[A' up-line-or-search 
% ls -l
total 1503
[snip]
% pwd
/home/jean-luc
% l_
   ^
   Cursor here, hit cursor-up -> beeps, because the _word_ l wasn't
   found in the history
% ls_
    ^
    Cursor here, hit cursor-up -> expands to ls -l

This behaviour seems to be OK, looking at the documentation...

Perhaps this can't be done in zsh-3.1.2 as it is now, we may need
something like "up-line-or-history-beginning-search-backward". ;-)

CU,
Thomas [using history-beginning-search-backward]

-- 
  -- Thomas Köhler   Email:  jean-luc@picard.franken.de
          <><                     jean-luc@mayn.de
   IRC: jeanluc  Channels:  #star_trek #linuxger #ixthys #knf
             WWW: http://home.pages.de/~jeanluc/


^ permalink raw reply	[flat|nested] 21+ messages in thread

* Zle bug
@ 1998-02-01  3:16 Wez Furlong
  1998-02-01 14:41 ` Thomas Köhler
  0 siblings, 1 reply; 21+ messages in thread
From: Wez Furlong @ 1998-02-01  3:16 UTC (permalink / raw)
  To: zsh-workers

Hi,

I am reporting a bug that is present in zsh 3.1.2 and also 3.1.2-zefram3.
I have mentioned it before (when 3.1.2 was first released) but it does not
appear to have been addressed.

Here's a demonstration:

% > zsh -f
% > echo $ZSH_VERSION
3.0.5
% > bindkey  '\e[A'   up-line-or-search
% > who
wez      tty3     Feb  1 00:37
root     tty4     Feb  1 00:42
root     tty2     Jan 31 16:51
wez      tty5     Feb  1 01:42
% > ls
Admin              Personal           UNI                root
Amiga              Povray             Wez-Crontab        spambounce.tar.gz
Dave               Src                mail.vim           tmp
PCMCIA             Stuff              mbox
% > w

At this point I press cursor up

% > who

This is correct.

And here is the bug, with 3.1.2:

% > zsh -f
% > echo $ZSH_VERSION
3.1.2
% > bindkey  '\e[A'   up-line-or-search
% > who
wez      tty3     Feb  1 00:37
root     tty4     Feb  1 00:42
root     tty2     Jan 31 16:51
wez      tty5     Feb  1 01:42
% > ls
Admin              Personal           UNI                root
Amiga              Povray             Wez-Crontab        spambounce.tar.gz
Dave               Src                mail.vim           tmp
PCMCIA             Stuff              mbox
% > w

Pressing cursor up produces a beep.

% > w


This is a feature which I use a lot, and it's a shame it is missing/broken. I
have tested this on the following:

Linux twinklestar 2.0.31 #4 Thu Dec 18 14:19:38 GMT 1997 m68k

And an SGI IRIX 5.3 system - we have had several older versions of zsh which
work correctly, but both builds of 3.1.2 and 3.1.2-zefram3 exhibit the broken
behaviour.

While on the subject of IRIX and zeframs baseline version, there were a couple
changes needed in order for the build to be successful. I had applied zeframs
diff, and the build diff to correct the bashisms (which failed on about 5
hunks - I tried the systems default patch, and the latest gnu patch - the gnu
version failed less hunks than the other).

After applying those hunks manually, I then had to edit Src/signames.awk and
Builtins/rlimits.awk and change the references to 034 to 042, as gawk (3.x)
was producing \^ (or something similar) instead of ". Note, however, that
042 is octal for 34 which is the ascii code for ". 034 is the ascii code for
FS, which is not really what is wanted. This could be a portability of
{g,m,n}awk issue - interpretation of different radices.

I hope you can sort out the zle thing, and also fix the build setup (I had to
get autoconf (for autoheader) which required gnu m4, and then apply patches by
hand etc. etc.) - the zefram version was very difficult to build on the
semi-stock IRIX setup.

I also hope this is a ``useful'' bug report. :-)

Thanks,

Wez.

--
Wez Furlong                        Undergrad - Electronic Systems Engineering
                                           http://www.twinklestar.demon.co.uk
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


^ permalink raw reply	[flat|nested] 21+ messages in thread

end of thread, other threads:[~1998-06-22 17:43 UTC | newest]

Thread overview: 21+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <aheading@jpmorgan.com>
1998-02-09 13:23 ` Zle bug Wez Furlong
1998-04-28 12:34   ` up-line-or-search still 'fixed'! Anthony Heading
1998-04-28 13:21     ` Andy Wick
1998-04-28 13:33     ` Anthony Heading
1998-04-28 14:08       ` Andrew Main
1998-06-09 13:13         ` Anthony Heading
1998-06-09 15:22           ` Bart Schaefer
1998-06-09 15:50             ` Bruce Stephens
1998-06-09 18:42               ` Bart Schaefer
1998-06-10 10:14                 ` Bruce Stephens
1998-06-10 10:31                   ` Zefram
1998-06-10 11:57                     ` Bruce Stephens
1998-06-10 17:13                       ` Bart Schaefer
1998-06-10  5:18             ` message numbers in mla Geoff Wing
1998-06-22 11:16               ` Geoff Wing
1998-06-22 16:17                 ` Bart Schaefer
1998-06-22 17:38                   ` Richard Coleman
1998-02-02  2:58 Zle bug Wez Furlong
  -- strict thread matches above, loose matches on Subject: below --
1998-02-01  3:16 Wez Furlong
1998-02-01 14:41 ` Thomas Köhler
1998-02-09 12:57   ` Anthony JR Heading

Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).