From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14961 invoked from network); 21 Feb 1998 14:05:31 -0000 Received: from math.gatech.edu (list@130.207.146.50) by ns1.primenet.com.au with SMTP; 21 Feb 1998 14:05:31 -0000 Received: (from list@localhost) by math.gatech.edu (8.8.5/8.8.5) id IAA22515; Sat, 21 Feb 1998 08:46:28 -0500 (EST) Resent-Date: Sat, 21 Feb 1998 08:46:28 -0500 (EST) Message-ID: <19980221134837.35279@thelonious.new.ox.ac.uk> Date: Sat, 21 Feb 1998 13:48:37 +0000 From: Adam Spiers To: Zsh hackers list Subject: PATCH: complete-history Reply-To: Adam Spiers References: <19980220175020.58576@thelonious.new.ox.ac.uk> <199802211002.LAA23105@sgi.ifh.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 0.84 In-Reply-To: <199802211002.LAA23105@sgi.ifh.de>; from Peter Stephenson on Sat, Feb 21, 1998 at 11:02:40AM +0100 Resent-Message-ID: <"qxVbe2.0.kV5.qgjxq"@math> Resent-From: zsh-workers@math.gatech.edu X-Mailing-List: archive/latest/3777 X-Loop: zsh-workers@math.gatech.edu Precedence: list Resent-Sender: zsh-workers-request@math.gatech.edu Peter Stephenson (pws@ifh.de) wrote: > Adam Spiers wrote: > > While we're on the subject of patching zle_tricky.c etc., has > > anyone had a chance to try my dabbrev patch yet? I'm quite keen > > to get some feedback on it. Should I release it to zsh-users > > for testing if everyone here is too busy to check it out? > > I haven't tried it because I assumed it did the same job as my > completion patch where you can bind special sorts of completion to a > key (zle -C complete-history -H '' 0; bindkey "\M-/" > complete-history). Maybe I got the wrong end of the stick? Nope, I don't think you did ... I guess the moral of this story is, if you're a newbie who asks on zsh-users whether something is possible, gets no response and decides to write a patch to do it, join zsh-workers before you start work on it rather than when it's ready for release :-/ Sorry if this is a silly question, but where can I get your patch? It sounds a bit more generalised than the one you posted here dated 16th Jan 1998. My patch is very similar to the latter, with some small differences: - yours is probably better, as you know far more about zsh internals - yours doesn't have a reverse-complete-history thing (correct me if I'm wrong) - I introduced an extra state to `validlist' so that if you press M-/ and then TAB it reverts to the normal completion. -- Adam Spiers, Computing Officer, New College, Oxford University, UK ** cello/modern jazz/juggling/cycling/Perl/Linux/Quake fanatic, M$ hater e-mail: adam.spiers@new.ox.ac.uk WWW: http://www.new.ox.ac.uk/~adam/