From: Peter Stephenson <pws@ifh.de>
To: zsh-workers@math.gatech.edu (Zsh hackers list)
Subject: PATCH: don't read tty settings in zle
Date: Wed, 25 Mar 1998 15:19:43 +0100 [thread overview]
Message-ID: <199803251419.PAA20465@hydra.ifh.de> (raw)
(Look! There's real grammar in the subject line this time. Or,
subject line grammar reality surprise, as I would usually put it.)
Some time ago I complained that zsh was messing up my tty settings
when I killed jobs in the background. I've had a closer look and
found out it wasn't that simple. I have a completion function for
kill which prints the job name as a comment after %no, and I
habitually use it for killing things since I'm lazy. It was _this_
job exiting which caused the tty setting to be read, and since zle was
active they were messed up: nothing to do with genuine job control.
The answer is easy: don't get the current tty settings when zle is
active. This patch is for 3.1.x, but probably applies to 3.0.5, too.
*** Src/jobs.c.stty Tue Jan 13 11:41:56 1998
--- Src/jobs.c Wed Mar 25 15:07:12 1998
***************
*** 190,196 ****
}
}
! if (shout && !ttyfrozen && !jn->stty_in_env &&
job == thisjob && !somestopped && !(jn->stat & STAT_NOSTTY))
gettyinfo(&shttyinfo);
--- 190,196 ----
}
}
! if (shout && !ttyfrozen && !jn->stty_in_env && !zleactive &&
job == thisjob && !somestopped && !(jn->stat & STAT_NOSTTY))
gettyinfo(&shttyinfo);
--
Peter Stephenson <pws@ifh.de> Tel: +39 50 844536
WWW: http://www.ifh.de/~pws/
Gruppo Teorico, Dipartimento di Fisica
Piazza Torricelli 2, 56100 Pisa, Italy
next reply other threads:[~1998-03-25 14:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
1998-03-25 14:19 Peter Stephenson [this message]
1998-03-25 16:47 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=199803251419.PAA20465@hydra.ifh.de \
--to=pws@ifh.de \
--cc=zsh-workers@math.gatech.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).