From: Zoltan Hidvegi <hzoli@cs.elte.hu>
To: zsh-workers@math.gatech.edu (Zsh hacking and development)
Subject: PATCH: fix read -k coredump
Date: Fri, 8 May 1998 01:25:41 -0500 (CDT) [thread overview]
Message-ID: <199805080626.BAA02707@hzoli.home> (raw)
This fixes an off-by-one allocation bug.
Zoli
*** Src/builtin.c 1997/07/13 05:24:42 3.1.3.3
--- Src/builtin.c 1997/09/16 04:37:28 3.1.3.4
*************** bin_read(char *name, char **args, char *
*** 2792,2798 ****
char d;
/* allocate buffer space for result */
! bptr = buf = (char *)zalloc(nchars);
do {
/* If read returns 0, is end of file */
--- 2792,2798 ----
char d;
/* allocate buffer space for result */
! bptr = buf = (char *)zalloc(nchars+1);
do {
/* If read returns 0, is end of file */
*************** bin_read(char *name, char **args, char *
*** 2823,2829 ****
if (!ops['e'])
setsparam(reply, metafy(buf, bptr - buf, META_REALLOC));
else
! zfree(buf, bptr - buf);
return val <= 0;
}
--- 2823,2829 ----
if (!ops['e'])
setsparam(reply, metafy(buf, bptr - buf, META_REALLOC));
else
! zfree(buf, bptr - buf + 1);
return val <= 0;
}
reply other threads:[~1998-05-08 6:30 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=199805080626.BAA02707@hzoli.home \
--to=hzoli@cs.elte.hu \
--cc=zsh-workers@math.gatech.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).