zsh-workers
 help / color / mirror / code / Atom feed
* PATCH: glob coredump fix
@ 1998-05-09 20:13 Zoltan Hidvegi
  0 siblings, 0 replies; only message in thread
From: Zoltan Hidvegi @ 1998-05-09 20:13 UTC (permalink / raw)
  To: Zsh hacking and development

% ./zsh -f
% setopt extendedglob
% echo ((#))
zsh: bad pattern: ((#))
% echo *.c
zsh: 1779 segmentation fault (core dumped)  ./zsh -f

tail was assumed to be always NULL when pattern parsing was called.

3.0.5 already has this fix.  There were significant changes in glob.c
since 3.1.2, but this patch still seems to work.

Zoli


*** Src/glob.c.orig	Sat May  9 15:02:46 1998
--- Src/glob.c	Sat May  9 15:06:05 1998
*************** struct comp {
*** 125,131 ****
  #define GF_TOPLEV	2	/* outside (), so ~ ends main match */
  
  static char *pptr;		/* current place in string being matched */
! static Comp tail = 0;
  static int first;		/* are leading dots special? */
  
  /**/
--- 125,131 ----
  #define GF_TOPLEV	2	/* outside (), so ~ ends main match */
  
  static char *pptr;		/* current place in string being matched */
! static Comp tail;
  static int first;		/* are leading dots special? */
  
  /**/
*************** parsepat(char *str)
*** 802,807 ****
--- 802,808 ----
  {
      mode = 0;			/* path components present */
      pptr = str;
+     tail = NULL;
      return parsecomplist();
  }
  
*************** parsereg(char *str)
*** 2434,2439 ****
--- 2435,2441 ----
      remnulargs(str);
      mode = 1;			/* no path components */
      pptr = str;
+     tail = NULL;
      return parsecompsw(GF_TOPLEV);
  }
  


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~1998-05-09 22:54 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
1998-05-09 20:13 PATCH: glob coredump fix Zoltan Hidvegi

Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).