From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1263 invoked from network); 5 Nov 1998 10:51:44 -0000 Received: from math.gatech.edu (list@130.207.146.50) by ns1.primenet.com.au with SMTP; 5 Nov 1998 10:51:44 -0000 Received: (from list@localhost) by math.gatech.edu (8.9.1/8.9.1) id FAA21838; Thu, 5 Nov 1998 05:49:36 -0500 (EST) Resent-Date: Thu, 5 Nov 1998 05:49:36 -0500 (EST) Date: Thu, 5 Nov 1998 11:47:38 +0100 (MET) Message-Id: <199811051047.LAA31031@beta.informatik.hu-berlin.de> From: Sven Wischnowsky To: zsh-workers@math.gatech.edu In-reply-to: "Bart Schaefer"'s message of Wed, 4 Nov 1998 09:31:12 -0800 Subject: Re: bug in 3.1.4 completion Resent-Message-ID: <"0cqnv.0.9L5._AOGs"@math> Resent-From: zsh-workers@math.gatech.edu X-Mailing-List: archive/latest/4553 X-Loop: zsh-workers@math.gatech.edu Precedence: list Resent-Sender: zsh-workers-request@math.gatech.edu Bart Schaefer wrote: > On Nov 4, 10:04am, Sven Wischnowsky wrote: > } Subject: Re: bug in 3.1.4 completion > } > } There was a missing fixsuffix() when inserting the unambiguous string > } for normal completion. [...] > } > } Here is another missing call to fixsuffix() (fixed by the first > } hunk). [...] > > There seem to be an awful lot of completion bugs related to missing or > misplaced calls to fixsuffix(). Those bugs weren't present in 3.0.5. > I was was not paying much attention to 3.1 until just before 3.1.4 (too > busy with "real life") so I sort of glossed over all the changes that > turned zle into a module, etc. Was whatever reorganization required > the addition of fixsuffix() really a good idea? It doesn't -seem- like > something that should need to be done in so many different places ... It isn't that bad, three calls in zle_misc.c and three in zle_tricky.c. I just had some trouble inserting it in all the places where the completion code changes the line (the one in delete-char-or-list was something special since there I had to insert it in the if-branch that *didn't* call the completion code, it should have been there from the beginning). We could try to replace the calls we have now by calls in those functions that actually alter the command line (shiftline(), inststrlen(), and the like). This probably doesn't reduce the number of calls but it may ensure that there aren't any places where these functions are called and fixsuffix() is not called. But since I didn't write the fixsuffix() code I'd rather not fiddle with it. Bye Sven -- Sven Wischnowsky wischnow@informatik.hu-berlin.de