From: Sven Wischnowsky <wischnow@informatik.hu-berlin.de>
To: zsh-workers@math.gatech.edu
Subject: Re: Two more (possible) problems with the new completion...
Date: Thu, 5 Nov 1998 13:05:24 +0100 (MET) [thread overview]
Message-ID: <199811051205.NAA31465@beta.informatik.hu-berlin.de> (raw)
In-Reply-To: Peter Stephenson's message of Thu, 05 Nov 1998 12:06:22 +0100
Peter Stephenson wrote:
>
> Maybe these are just the result of badly applied patches, like the
> last two, but if they are I'll never know without asking...
>
> 1) The following works (and very useful it is, too: goodbye, cdmatch):
>
> compctl -W "($cdpath)" -/ cd
>
> but the following, which as far as I can see should be equivalent
> apart from tracking changes in $cdpath, doesn't:
>
> compctl -W '$cdpath' -/ cd
>
> (no matches produced).
>
`-W' behaves like `-k', you only need `compctl -W cdpath -/ cd'. There
is some extra hacklet that ensures that the old style (giving one
directory) still works (in most cases): if the string isn't an
parameter name, it is used directly as a directory name. So, unless
you have a directory named `$cdpath' (*not* the value of `cdpath') it
will produce no matches.
>
> 2) I suppose this is more than a misplaced fixsuffix(); you need
> menucompletion set, though setting automenu and hitting <TAB> twice
> has the same effect:
>
> compctl -q -S / -k '(foo bar)' echo
> ^^^^^^^ this is the important bit
>
> % echo <TAB> -> bar/
> ^cursor here, over the slash
>
> followed by <RET>:
>
> % echo ba/
> ba/
>
> so at some point the cursor is being put one character too far back.
> It doesn't happen with a `genuine' autoremoveslash.
This is a real bug (there really is an embarassing number of them,
sigh). The cursor should be moved on the suffix only when completing
inside words (paths, whatever).
Bye
Sven
*** os/Zle/zle_tricky.c Thu Nov 5 13:02:37 1998
--- Src/Zle/zle_tricky.c Thu Nov 5 13:02:45 1998
***************
*** 5068,5074 ****
if (menuwe && m->ripre && isset(AUTOPARAMKEYS))
makeparamsuffix(((m->flags & CMF_PARBR) ? 1 : 0), menuinsc);
! if (menucmp)
cs = menuend;
}
--- 5068,5074 ----
if (menuwe && m->ripre && isset(AUTOPARAMKEYS))
makeparamsuffix(((m->flags & CMF_PARBR) ? 1 : 0), menuinsc);
! if (menucmp && !menuwe)
cs = menuend;
}
--
Sven Wischnowsky wischnow@informatik.hu-berlin.de
next reply other threads:[~1998-11-05 12:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
1998-11-05 12:05 Sven Wischnowsky [this message]
1998-11-05 12:44 ` PATCH: " Peter Stephenson
1998-11-05 12:56 ` Peter Stephenson
-- strict thread matches above, loose matches on Subject: below --
1998-11-05 11:06 Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=199811051205.NAA31465@beta.informatik.hu-berlin.de \
--to=wischnow@informatik.hu-berlin.de \
--cc=zsh-workers@math.gatech.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).