From: Sven Wischnowsky <wischnow@informatik.hu-berlin.de>
To: zsh-workers@math.gatech.edu
Subject: Re: PATCH: 3.1.5-pws-3: (subscripts) Re: Problem with associative arrays
Date: Thu, 17 Dec 1998 12:53:14 +0100 (MET) [thread overview]
Message-ID: <199812171153.MAA09925@beta.informatik.hu-berlin.de> (raw)
In-Reply-To: "Bart Schaefer"'s message of Wed, 16 Dec 1998 09:53:09 -0800
Bart Schaefer wrote:
>
> On Dec 16, 3:31pm, Sven Wischnowsky wrote:
> } Subject: Problem with associative arrays
> }
> } And this time it's for real:
> }
> } % typeset -A a
> } % a[x*]=foo
> } zsh: bad math expression: unbalanced stack
> } % echo $a[x*]
> } foo
> } %
> }
> } The problem is that isident() uses mathevalarg() to skip (!) over the
> } contents of a subscript (unless the subscript contains flags).
>
> isident() seems to be rather inconsistent about strict checking of the
> text inside the [ ]. Below is the most obvious fix (#ifdef'd for now).
...minus one `s', it seems:
% typeset -A a
% a[--foo--]=bar
zsh: not an identifier: a[--foo--]
Bye
Sven
*** os/params.c Thu Dec 17 12:20:23 1998
--- Src/params.c Thu Dec 17 12:49:07 1998
***************
*** 663,669 ****
/* Require balanced [ ] pairs */
for (s = ss; *(s += strcspn(++ss, "[]")) && s > ss; ss = s)
;
! return (*ss == ']' && !s[1]);
#endif
}
--- 663,669 ----
/* Require balanced [ ] pairs */
for (s = ss; *(s += strcspn(++ss, "[]")) && s > ss; ss = s)
;
! return (*ss == ']' && !ss[1]);
#endif
}
--
Sven Wischnowsky wischnow@informatik.hu-berlin.de
next reply other threads:[~1998-12-17 12:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
1998-12-17 11:53 Sven Wischnowsky [this message]
1998-12-17 12:46 ` Bart Schaefer
-- strict thread matches above, loose matches on Subject: below --
1998-12-16 14:31 Sven Wischnowsky
1998-12-16 17:53 ` PATCH: 3.1.5-pws-3: (subscripts) " Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=199812171153.MAA09925@beta.informatik.hu-berlin.de \
--to=wischnow@informatik.hu-berlin.de \
--cc=zsh-workers@math.gatech.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).