Re: Identifier bug

Re: Identifier bug

[Sven Wischnowsky]

Peter Stephenson wrote:

> 
> I was just about to put together another development version when I
> discovered this.
> 
> % foo=(a b)
> % foo[1]=c
> zsh: not an identifier: foo[1]

Ok, now I dare to propose this one.

But note that this still has problems if the string inside the `[...]'
contains unmatched opening or closing brackets.

Bye
 Sven

*** os/params.c	Thu Dec 17 15:06:20 1998
--- Src/params.c	Fri Dec 18 11:56:53 1998
***************
*** 661,669 ****
  	return 0;
  
      /* Require balanced [ ] pairs */
!     for (s = ss; *(s += strcspn(++ss, "[]")) && s > ss; ss = s)
! 	;
!     return (*ss == ']' && !ss[1]);
  #endif
  }
  
--- 661,669 ----
  	return 0;
  
      /* Require balanced [ ] pairs */
!     if (skipparens('[', ']', &ss))
! 	return 0;
!     return !*ss;
  #endif
  }
  

--
Sven Wischnowsky                         wischnow@informatik.hu-berlin.de

Re: Identifier bug

[Peter Stephenson]

Sven Wischnowsky wrote:
> Ok, now I dare to propose this one.

That, I understand.  I spent 10 minutes trying to work out what the
strcpsn() was supposed to do.

> But note that this still has problems if the string inside the `[...]'
> contains unmatched opening or closing brackets.

Probably the right thing to do in the long term is have the opening
and closing brackets remaining tokenized.  Then if there is an
unbalanced ] in the middle inside quotes it won't be seen as a
delimiter.  If it's not quoted, of course, you have the seem problem,
but that's just down to the syntax.

-- 
Peter Stephenson <pws@ibmth.df.unipi.it>       Tel: +39 050 844536
WWW:  http://www.ifh.de/~pws/
Dipartimento di Fisica, Via Buonarroti 2, 56127 Pisa, Italy

Identifier bug

[Peter Stephenson]

I was just about to put together another development version when I
discovered this.

% foo=(a b)
% foo[1]=c
zsh: not an identifier: foo[1]

which is quite serious, because my functions use this all the time, so
I'll have to wait until it's fixed.  I would guess the problem is with
4826, fixing subscripts for associative arrays.

-- 
Peter Stephenson <pws@ibmth.df.unipi.it>       Tel: +39 050 844536
WWW:  http://www.ifh.de/~pws/
Dipartimento di Fisica, Via Buonarroti 2, 56127 Pisa, Italy