zsh-workers
 help / color / mirror / code / Atom feed
From: opk@thoth.u-net.com (Oliver Kiddle)
To: zsh-workers@math.gatech.edu
Subject: PATCH: Small fix for dynamic loading on IRIX 5.3
Date: Sat, 9 Jan 1999 14:37:01 +0000	[thread overview]
Message-ID: <199901091437.OAA09811@Indigo.thoth.u-net.com> (raw)

When trying to compile zsh (either 3.1.5 or 3.1.5-pws-4) with dynamic
loading enabled on IRIX 5.3, I found that the dynamic code was not
being compiled despite the fact that it has worked well with previous
versions. I traced this down to the following line in configure:

checking if static/shared library linking is broken... yes
config.log showed the problem as:

configure:4642: checking if static/shared library linking is broken
cfe: Error: conftest1.c, line 5: Too many initial values for 'symlist1'
                (void *)0
                ^
Anyway, the problem is the section of code in aczsh.m4 for conftest1.c:
        extern char **environ;
        void *symlist1[] = {
                (void *)&environ,
                (void *)0
        };

The '[]' is being lost by autoconf so that the line of code in the
configure script appears as just:
        void *symlist1 = {
and SGI's compiler doesn't like this. With the correct conftest1/2
files compiled, the test would pass.

If I'm not mistaken, this is because autoconf sets [ and ] to be the m4
quoting characters. The fix is to use [[]]. I have attached a small
patch which fixes this (although you'll probably find it easier to redo
the change manually).

Oliver Kiddle

*** aczsh.m4	Fri Dec 18 08:48:01 1998
--- aczsh.m4	Sat Jan  9 14:22:32 1999
***************
*** 45,51 ****
  fi
  echo '
  	extern char **environ;
! 	void *symlist1[] = {
  		(void *)&environ,
  		(void *)0
  	};
--- 45,51 ----
  fi
  echo '
  	extern char **environ;
! 	void *symlist1[[]] = {
  		(void *)&environ,
  		(void *)0
  	};


                 reply	other threads:[~1999-01-09 15:27 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=199901091437.OAA09811@Indigo.thoth.u-net.com \
    --to=opk@thoth.u-net.com \
    --cc=zsh-workers@math.gatech.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).