From: Sven Wischnowsky <wischnow@informatik.hu-berlin.de>
To: zsh-workers@sunsite.auc.dk
Subject: Re: PATCH: zsh-3.1.5-pws-6: bash-style completion
Date: Thu, 4 Feb 1999 15:05:23 +0100 (MET) [thread overview]
Message-ID: <199902041405.PAA17387@beta.informatik.hu-berlin.de> (raw)
In-Reply-To: Peter Stephenson's message of Thu, 04 Feb 1999 12:22:32 +0100
Peter Stephenson wrote:
> I've also been having strange effects when combining all this with:
> compctl -M 'm:{a-z}={A-Z}' 'r:|[.,_-]=* r:|=*'
> but I haven't tracked it down (and it's there anyway, I just normally
> use menu completion so hadn't noticed). I think there may be a
> problem with `compctl -M' on its own, too, since I got a crash after
> that once.
Hm, I haven't found any unusual behavior here, so I guess, I need an
example.
>From the patch in do_ambiguous():
> * We don't do this when BASH_AUTO_LIST is set, because that would *
> * mean you only got a completion list the third time you hit tab *
> * (or whichever key). */
> if(isset(LISTAMBIGUOUS) && !isset(BASHAUTOLIST) && !am &&
I have only a bash-2.01.1 here but that version shows the behavior to
list the matches only on the third TAB: 1) insert unambiguous prefix,
2) do nothing, 3) show list. If the unambiguous prefix was completely
typed (not automatically inserted), it first does nothing and shows
the list on the second TAB. So I'd vote for removing the test, see the
patch below which also fixes a typo in your patch. Otherwise using
BASHAUTOLIST will be the same as LISTAMBIGUOUS+AUTOLIST if the
unambiguous prefix had to be automatically inserted.
Bye
Sven
--- Src/Zle/zle_tricky.c.old Thu Feb 4 14:53:53 1999
+++ Src/Zle/zle_tricky.c Thu Feb 4 14:59:31 1999
@@ -303,7 +303,7 @@
else {
if (lastambig == 1 && isset(BASHAUTOLIST) && !usemenu && !menucmp) {
docomplete(COMP_LIST_COMPLETE);
- lastambig == 2;
+ lastambig = 2;
} else
docomplete(COMP_COMPLETE);
}
@@ -5484,7 +5484,7 @@
* We don't do this when BASH_AUTO_LIST is set, because that would *
* mean you only got a completion list the third time you hit tab *
* (or whichever key). */
- if(isset(LISTAMBIGUOUS) && !isset(BASHAUTOLIST) && !am &&
+ if(isset(LISTAMBIGUOUS) && !am &&
(ics != cs || (ainfo->suflen && !atend))) {
invalidatelist();
lastambig = 0;
--
Sven Wischnowsky wischnow@informatik.hu-berlin.de
next reply other threads:[~1999-02-04 14:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
1999-02-04 14:05 Sven Wischnowsky [this message]
1999-02-04 14:12 ` Peter Stephenson
1999-02-04 15:26 ` Bart Schaefer
-- strict thread matches above, loose matches on Subject: below --
1999-02-05 9:51 Sven Wischnowsky
1999-02-05 8:28 Sven Wischnowsky
1999-02-05 9:17 ` Peter Stephenson
1999-02-04 14:40 Dag-Erling Smorgrav
1999-02-04 11:48 Sven Wischnowsky
1999-02-04 8:15 [PATCH] " Sven Wischnowsky
1999-02-04 11:22 ` PATCH: zsh-3.1.5-pws-6: " Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=199902041405.PAA17387@beta.informatik.hu-berlin.de \
--to=wischnow@informatik.hu-berlin.de \
--cc=zsh-workers@sunsite.auc.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).