From: Bart Schaefer <schaefer@tiny.zanshin.com>
To: Sven Wischnowsky <wischnow@informatik.hu-berlin.de>
Cc: zsh-workers@sunsite.auc.dk
Subject: Re: PATCH: 3.1.5-pws-8: setting duplicate elements of assoc array
Date: Fri, 19 Feb 1999 15:59:33 -0800 [thread overview]
Message-ID: <199902192359.PAA00764@tiny.zanshin.com> (raw)
In-Reply-To: <199902190858.JAA09439@beta.informatik.hu-berlin.de>
Sven Wischnowsky writes:
>
> I forgot to tokenize the '{' and '}'. This makes me think that the
> ctokenize() function should be joined with tokenize() even more,
> giving tokenize() an extra argument. But I'm reluctant to change every
> call to tokenize()...
So don't. The argument would be the same for almost every existing
instance of tokenize(), right? Do it this way (no 3.1.5 source code
handy, pardon the psuedo-code):
static void
full_tokenize(char *s, int extra_arg) /* choose more appropriate name */
{
/* combined guts of tokenize() and ctokenize() here */
}
/**/
void
tokenize(char *s)
{
full_tokenize(s, something);
}
/**/
void
ctokenize(char *s)
{
full_tokenize(s, otherthing);
}
Then change only the calls that actually need the new argument, to
call the new full_tokenize() function.
next prev parent reply other threads:[~1999-02-20 11:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
1999-02-19 8:58 Sven Wischnowsky
1999-02-19 23:59 ` Bart Schaefer [this message]
-- strict thread matches above, loose matches on Subject: below --
1999-02-18 17:17 Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=199902192359.PAA00764@tiny.zanshin.com \
--to=schaefer@tiny.zanshin.com \
--cc=schaefer@brasslantern.com \
--cc=wischnow@informatik.hu-berlin.de \
--cc=zsh-workers@sunsite.auc.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).