From: Sven Wischnowsky <wischnow@informatik.hu-berlin.de>
To: zsh-workers@sunsite.auc.dk
Subject: PATCH: unset and assoc (was Re: Let's finish this new completion stuff)
Date: Tue, 23 Feb 1999 13:54:07 +0100 (MET) [thread overview]
Message-ID: <199902231254.NAA24702@beta.informatik.hu-berlin.de> (raw)
In-Reply-To: "Bart Schaefer"'s message of Sun, 21 Feb 1999 16:15:42 -0800
Bart Schaefer wrote:
> zagzig% typeset -A foo
> zagzig% echo ${+foo[x]}
> 1
> zagzig% typeset -a bar
> zagzig% echo ${+bar[x]}
> 0
>
> That is, all fields of associative arrays currently appear to be set,
> even when they aren't; this is not true of plain arrays.
The problem was that at the time the lookup in the hastable occurs,
there is an struct pm for it with the PM_UNSET flag set. The patch
below makes this flag be tested in subst.c. I think this is the
simplest solution and the tests I did worked, does anyone see any
problems with this?
Bye
Sven
--- os/subst.c Mon Feb 22 10:49:23 1999
+++ Src/subst.c Tue Feb 23 13:47:42 1999
@@ -999,11 +999,12 @@
if (!(v = fetchvalue((subexp ? &ov : &s), (wantt ? -1 :
((unset(KSHARRAYS) || inbrace) ? 1 : -1)),
- hkeys|hvals)))
+ hkeys|hvals)) ||
+ (v->pm && (v->pm->flags & PM_UNSET)))
vunset = 1;
if (wantt) {
- if (v) {
+ if (v && v->pm && !(v->pm->flags & PM_UNSET)) {
int f = v->pm->flags;
switch (PM_TYPE(f)) {
--
Sven Wischnowsky wischnow@informatik.hu-berlin.de
next reply other threads:[~1999-02-23 12:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
1999-02-23 12:54 Sven Wischnowsky [this message]
1999-02-23 18:38 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=199902231254.NAA24702@beta.informatik.hu-berlin.de \
--to=wischnow@informatik.hu-berlin.de \
--cc=zsh-workers@sunsite.auc.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).