From: Sven Wischnowsky <wischnow@informatik.hu-berlin.de>
To: zsh-workers@sunsite.auc.dk
Subject: Re: PATCH: completion parameters etc.
Date: Mon, 1 Mar 1999 14:29:26 +0100 (MET) [thread overview]
Message-ID: <199903011329.OAA13941@beta.informatik.hu-berlin.de> (raw)
In-Reply-To: Peter Stephenson's message of Mon, 01 Mar 1999 14:04:03 +0100
Peter Stephenson wrote:
> There's a stray zsfree(compcommand) in finish_comp1() in comp1.c;
> compcommand is not mentioned anywhere else any more, can I just delete it?
> Also, there's a pm_type(...) in compunsetfn in compctl.c, that should
> probably be PM_TYPE(...).
But here I could compile it... that's what you get for using
dynamically loaded modules, I guess.
Bye
Sven
diff -u os/Zle/comp1.c Src/Zle/comp1.c
--- os/Zle/comp1.c Mon Mar 1 13:20:06 1999
+++ Src/Zle/comp1.c Mon Mar 1 14:28:27 1999
@@ -457,11 +457,20 @@
deletehashtable(compctltab);
zfree(clwords, clwsize * sizeof(char *));
compctlreadptr = fallback_compctlread;
- zsfree(compcontext);
- zsfree(compcommand);
+ freearray(compwords);
zsfree(compprefix);
- zsfree(compiprefix);
zsfree(compsuffix);
+ zsfree(compiprefix);
+ zsfree(compmatcherstr);
+ zsfree(compcontext);
+ zsfree(compparameter);
+ zsfree(compredirect);
+ zsfree(compquote);
+ zsfree(compquoting);
+ zsfree(comprestore);
+ zsfree(complist);
+ zsfree(compinsert);
+ zsfree(compexact);
return 0;
}
diff -u os/Zle/compctl.c Src/Zle/compctl.c
--- os/Zle/compctl.c Mon Mar 1 13:20:06 1999
+++ Src/Zle/compctl.c Mon Mar 1 14:26:47 1999
@@ -1960,7 +1960,7 @@
if (PM_TYPE(pm->flags) == PM_SCALAR) {
zsfree(*((char **) pm->u.data));
*((char **) pm->u.data) = ztrdup("");
- } else if (pm_type(pm->flags) == PM_ARRAY) {
+ } else if (PM_TYPE(pm->flags) == PM_ARRAY) {
freearray(*((char ***) pm->u.data));
*((char ***) pm->u.data) = zcalloc(sizeof(char *));
}
--
Sven Wischnowsky wischnow@informatik.hu-berlin.de
next reply other threads:[~1999-03-01 13:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
1999-03-01 13:29 Sven Wischnowsky [this message]
-- strict thread matches above, loose matches on Subject: below --
1999-03-01 12:41 Sven Wischnowsky
1999-03-01 12:10 Sven Wischnowsky
1999-03-01 12:31 ` Andrej Borsenkow
1999-03-01 13:04 ` Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=199903011329.OAA13941@beta.informatik.hu-berlin.de \
--to=wischnow@informatik.hu-berlin.de \
--cc=zsh-workers@sunsite.auc.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).