From: Sven Wischnowsky <wischnow@informatik.hu-berlin.de>
To: zsh-workers@sunsite.auc.dk
Subject: Re: Worrisome warnings after recent patches
Date: Thu, 4 Mar 1999 08:50:47 +0100 (MET) [thread overview]
Message-ID: <199903040750.IAA01987@beta.informatik.hu-berlin.de> (raw)
In-Reply-To: Bart Schaefer's message of Wed, 3 Mar 1999 16:49:45 -0800 (PST)
Bart Schaefer wrote (in a mail directly to me):
> ../../../zsh-3.1.5/Src/Zle/zle_tricky.c: In function `join_strs':
> ../../../zsh-3.1.5/Src/Zle/zle_tricky.c:1803: warning: `mp' might be used uninitialized in this function
> ../../../zsh-3.1.5/Src/Zle/zle_tricky.c: In function `join_ends':
> ../../../zsh-3.1.5/Src/Zle/zle_tricky.c:1930: warning: `tn' might be used uninitialized in this function
>
> ... [ more of these warnings ]
The first one really was wrong, but in the other cases the variables
could not have been used uninitialized, partly due to the calling
context but in most cases due to the tests in the functions
themselves.
Bye
Sven
diff -u os/Zle/zle_tricky.c Src/Zle/zle_tricky.c
--- os/Zle/zle_tricky.c Wed Mar 3 17:22:42 1999
+++ Src/Zle/zle_tricky.c Thu Mar 4 08:44:58 1999
@@ -1873,7 +1873,7 @@
if (!t)
break;
} else {
- if (rr <= mp->llen) {
+ if (rr <= 1) {
char *or = rs;
rs = realloc(rs, (rl += 20));
@@ -1927,7 +1927,7 @@
} else {
/* Different anchors, see if we can find matching anchors
* further down the lists. */
- Cline to, tn;
+ Cline to, tn = NULL;
int t = 0;
/* But first build the common prefix. */
@@ -3414,6 +3414,7 @@
}
}
while (ll && lw) {
+ t = 0;
/* First try the matchers. */
for (ms = mstack; ms; ms = ms->next) {
for (mp = ms->matcher; mp; mp = mp->next) {
@@ -3655,6 +3656,7 @@
}
}
while (ll && lw) {
+ t = 0;
for (ms = mstack; ms; ms = ms->next) {
for (mp = ms->matcher; mp; mp = mp->next) {
if (lm == mp)
@@ -3984,11 +3986,12 @@
char *suf, char *group, char *rems, char *remf, char *ign,
int flags, int aflags, Cmatcher match, char *exp, char **argv)
{
- char *s, *t, *e, *me, *ms, *lipre = NULL, *lpre, *lsuf, **aign = NULL;
- int lpl, lsl, i, pl, sl, test, bpl, bsl, llpl, llsl;
- Aminfo ai;
+ char *s, *t, *e, *me, *ms, *lipre = NULL, *lpre = NULL, *lsuf = NULL;
+ char **aign = NULL;
+ int lpl, lsl, i, pl, sl, test, bpl, bsl, llpl = 0, llsl = 0;
+ Aminfo ai = NULL;
Cline lc = NULL;
- LinkList l;
+ LinkList l = NULL;
Cmatch cm;
struct cmlist mst;
Cmlist oms = mstack;
@@ -4132,7 +4135,7 @@
}
/* Walk through the matches given. */
for (; (s = dupstring(*argv)); argv++) {
- sl = strlen(s);
+ sl = pl = strlen(s);
lc = NULL;
ms = NULL;
bpl = brpl;
@@ -5742,7 +5745,7 @@
Compcond or, cc;
Comp comp;
int compadd, m = 0, d = 0, t, tt, i, j, a, b;
- char *sc, *s, *ss;
+ char *sc = NULL, *s, *ss;
/* This loops over the patterns separated by `-'s. */
for (compc = occ->ext; compc; compc = compc->next) {
@@ -7871,7 +7874,7 @@
}
}
else if (g->lcount) {
- int n = g->lcount, nl = (n + ncols - 1) / ncols, nc = nl, i, j, a;
+ int n = g->lcount, nl = (n + ncols - 1) / ncols, nc = nl, i, j, a = 0;
Cmatch *q;
if (n && pnl) {
--
Sven Wischnowsky wischnow@informatik.hu-berlin.de
next reply other threads:[~1999-03-04 7:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
1999-03-04 7:50 Sven Wischnowsky [this message]
1999-03-04 8:31 ` 0 vs. NULL (RE: Worrisome warnings after recent patches) Andrej Borsenkow
1999-03-04 8:42 ` Bernd Eggink
1999-03-04 10:35 ` Bruce Stephens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=199903040750.IAA01987@beta.informatik.hu-berlin.de \
--to=wischnow@informatik.hu-berlin.de \
--cc=zsh-workers@sunsite.auc.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).