zsh-workers
 help / color / mirror / code / Atom feed
From: Sven Wischnowsky <wischnow@informatik.hu-berlin.de>
To: zsh-workers@sunsite.auc.dk
Subject: Re: PATCH: small parameter fix
Date: Tue, 9 Mar 1999 09:19:12 +0100 (MET)	[thread overview]
Message-ID: <199903090819.JAA12538@beta.informatik.hu-berlin.de> (raw)
In-Reply-To: Peter Stephenson's message of Mon, 08 Mar 1999 16:55:08 +0100


Peter Stephenson wrote:

> in particular it has this effect:
> 
> % print "${$(uname -n)[1]}"
> ibmth
> 
> where you might guess $(...) in quotes produced a scalar for subscripting
> --- indeed it did, but the subscripting decided to treat it as an array
> element.  In fact, since the nested substitution recognises the quotes
> whereas the subscripting doesn't, you get,
> 
> % print "${${path}[1]}"
> /home/user2/pws/bin /home/user2/pws/links /home/user2/pws/mh/bin
> /home/user2/pws/scripts /usr/local/bin /usr/sue/bin /usr/bin /usr/bin/X11
> /usr/ucb /usr/local/bin/X11 /cern/pro/bin /usr/local/cap /etc .
> 
> (wrapped a bit --- well, you don't get that, but I do) which is distinctly
> on the strange side.  I would suggest that in quotes the old behaviour
> character-subscripting behaviour is the right one.

With the patch below we get:

  % echo ${$(uname -n)[1]}
  beta
  % echo "${$(uname -n)[1]}"
  b
  % echo ${${path}[1]}
  /users/wischnow/bin/alpha
  % echo "${${path}[1]}"
  /

...which seems sensible to me.

Bye
 Sven

--- os/subst.c	Mon Mar  8 09:51:27 1999
+++ Src/subst.c	Tue Mar  9 09:16:13 1999
@@ -976,7 +976,8 @@
 	skipparens(*s, *s == Inpar ? Outpar : Outbrace, &s);
 	sav = *s;
 	*s = 0;
-	if (multsub(&val, (aspar ? NULL : &aval), &isarr, NULL) && quoted) {
+	if (multsub(&val, ((quoted || aspar) ? NULL : &aval), &isarr, NULL) &&
+	    quoted) {
 	    isarr = -1;
 	    aval = alloc(sizeof(char *));
 	    aspar = 0;

--
Sven Wischnowsky                         wischnow@informatik.hu-berlin.de


             reply	other threads:[~1999-03-09  8:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
1999-03-09  8:19 Sven Wischnowsky [this message]
  -- strict thread matches above, loose matches on Subject: below --
1999-03-09 10:30 Sven Wischnowsky
1999-03-09 10:12 Sven Wischnowsky
1999-03-08  8:50 Sven Wischnowsky
1999-03-08  9:01 ` Bart Schaefer
1999-03-08 15:55   ` Peter Stephenson
1999-03-09  8:16     ` Andrej Borsenkow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=199903090819.JAA12538@beta.informatik.hu-berlin.de \
    --to=wischnow@informatik.hu-berlin.de \
    --cc=zsh-workers@sunsite.auc.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).