From: Sven Wischnowsky <wischnow@informatik.hu-berlin.de>
To: zsh-workers@sunsite.auc.dk
Subject: PATCH: tricky.c bug fix(es)
Date: Tue, 9 Mar 1999 15:19:49 +0100 (MET) [thread overview]
Message-ID: <199903091419.PAA14741@beta.informatik.hu-berlin.de> (raw)
With in-word completion and suffixes that caused the code to reduce it
to an empty common suffix this could lead to a SEGV.
And with the matching stuff we have now and in-word completion, we
should do the fignore-test in addmatch() even if there is a suffix.
Bye
Sven
--- os/Zle/zle_tricky.c Tue Mar 9 14:50:32 1999
+++ Src/Zle/zle_tricky.c Tue Mar 9 15:14:25 1999
@@ -2867,7 +2867,7 @@
o->suffix = join_new_sfx(o->suffix, n->wlen, n->word, &miss);
if (miss)
o->flags |= CLF_MISS;
- } else {
+ } else if (o->wlen && n->wlen) {
char so = o->word[o->wlen], sn = n->word[n->wlen];
char *new = o->word;
int newl = o->wlen, mol, mnl;
@@ -2893,7 +2893,8 @@
if (!o->suffix && n->wlen != o->wlen)
o->flags |= CLF_MISS;
- }
+ } else
+ o->wlen = 0;
}
/* Joins two Cline lists, building the most specific line string *
@@ -4417,7 +4418,8 @@
return;
if ((addwhat == CC_FILES ||
- addwhat == -5) && !*psuf && !*fsuf) {
+ addwhat == -5) && !*psuf) {
+ //---- && !*fsuf) {
/* If this is a filename, do the fignore check. */
char **pt = fignore;
int filell;
--
Sven Wischnowsky wischnow@informatik.hu-berlin.de
next reply other threads:[~1999-03-09 14:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
1999-03-09 14:19 Sven Wischnowsky [this message]
1999-03-09 14:44 Sven Wischnowsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=199903091419.PAA14741@beta.informatik.hu-berlin.de \
--to=wischnow@informatik.hu-berlin.de \
--cc=zsh-workers@sunsite.auc.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).