zsh-workers
 help / color / mirror / code / Atom feed
From: Sven Wischnowsky <wischnow@informatik.hu-berlin.de>
To: zsh-workers@sunsite.auc.dk
Subject: Re: Repeatable crash in latest zsh
Date: Wed, 10 Mar 1999 17:50:44 +0100 (MET)	[thread overview]
Message-ID: <199903101650.RAA17939@beta.informatik.hu-berlin.de> (raw)
In-Reply-To: Bart Schaefer's message of Wed, 10 Mar 1999 08:33:18 -0800 (PST)


Bart Schaefer wrote:

> This has been happening for about a week, I think, so it isn't something
> from the most recent patches, but it still happens even with everything
> posted so far.  This input:
> 
> zsh% setopt completeinword
> zsh% ZSH=<C-b><TAB>
> 
> (that is, expand-or-complete before the '=') causes `zsh -f` to crash.

The code was to eager to restrict the things to `the string after the
equal sign', forgetting to test if it was after it.

Bye
 Sven

--- os/Zle/zle_tricky.c	Wed Mar 10 10:49:47 1999
+++ Src/Zle/zle_tricky.c	Wed Mar 10 17:49:18 1999
@@ -1278,7 +1278,7 @@
 	    *s = sav;
 	    if (skipparens(Inbrack, Outbrack, &s) > 0 || s > tt + cs - wb)
 		s = NULL, inwhat = IN_MATH, insubscr = 1;
-	    else if (*s == '=') {
+	    else if (*s == '=' && cs > wb + (s - tt)) {
 		s++;
 		wb += s - tt;
 		t0 = STRING;

--
Sven Wischnowsky                         wischnow@informatik.hu-berlin.de


             reply	other threads:[~1999-03-10 16:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
1999-03-10 16:50 Sven Wischnowsky [this message]
  -- strict thread matches above, loose matches on Subject: below --
1999-03-10 16:33 Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=199903101650.RAA17939@beta.informatik.hu-berlin.de \
    --to=wischnow@informatik.hu-berlin.de \
    --cc=zsh-workers@sunsite.auc.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).