Re: Minor refresh problem with completion

Re: Minor refresh problem with completion

[Sven Wischnowsky]

I wrote:

> Andrej Borsenkow wrote:
> 
> > I have a feeling, that with new completion the complete line is refreshed
> > every time. I noted that, as my display flickers sometimes quite ugly. It's
> > getting worse, when logical line extends over several terminal lines ...
> > Anybody else seen it?
> 
> That's not restricted to the new completion. It's caused by the way
> `clearlist' (the variable that triggers clearing a list that may be
> beneath the prompt) works -- it forces a redisplay of the prompt.
> 
> I tried to do this in a more sophisticated way (moving the cursor
> under the prompt, clear to EOD, move cursor up), but couldn't get it
> to work with the rest of the redisplay code. I'm not one of the most
> knowledgeable persons with respect to the zle redisplay code, so I
> have to ask: can someone come up with a better imlpementation?

Of course, now that I tried it again, it seems to work (at least if
your terminal has the capability of clearing to EOD).

But still, Id' be glad if our refresh-code experts could have a look
at this, because the code now sets the cursor to the last column of
the last prompt line and gives out a TCCLEAREOD -- and doing that when 
not in the first column may be undefined on some terminals if I
remember correctly.

Bye
 Sven

diff -u oos/Zle/zle_refresh.c Src/Zle/zle_refresh.c
--- oos/Zle/zle_refresh.c	Mon Mar 29 10:36:48 1999
+++ Src/Zle/zle_refresh.c	Mon Mar 29 10:41:47 1999
@@ -254,10 +254,18 @@
 	return;
 
     if (clearlist) {
-	invalidatelist();
-	moveto(0, 0);
-	clearflag = 0;
-	resetneeded = 1;
+	if (tccan(TCCLEAREOD)) {
+	    int ovln = vln, ovcs = vcs;
+
+	    moveto(nlnct - 1, columns - 1);
+	    tcout(TCCLEAREOD);
+	    moveto(ovln, ovcs);
+	} else {
+	    invalidatelist();
+	    moveto(0, 0);
+	    clearflag = 0;
+	    resetneeded = 1;
+	}
 	clearlist = 0;
     }
 #ifdef HAVE_SELECT

--
Sven Wischnowsky                         wischnow@informatik.hu-berlin.de

CLEAREOD (Was: Minor refresh problem with completion)

[Geoff Wing]

Sven Wischnowsky <wischnow@informatik.hu-berlin.de> typed:
:Of course, now that I tried it again, it seems to work (at least if
:your terminal has the capability of clearing to EOD).
:
:But still, Id' be glad if our refresh-code experts could have a look
:at this, because the code now sets the cursor to the last column of
:the last prompt line and gives out a TCCLEAREOD -- and doing that when 
:not in the first column may be undefined on some terminals if I
:remember correctly.

Yes, TCCLEAREOD must be done from the first column.  Lots of terminals
will happily do it from anywhere, but....

I'll look into it (though that clearlist section is probably the only
main part of zle_refresh.c I _didn't_ write).  First I better build
pws-14, heh? :-)

BTW, anyone notice that individual message threads weren't happening
properly in recent articles in the mailing list archive (and not tell
me).  I'll fix that soon.

Regards,
-- 
Geoff Wing   <gcw@pobox.com>            Mobile : (Australia) 0412 162 441
Work URL: http://www.primenet.com.au/   Ego URL: http://pobox.com/~gcw/

Re: Minor refresh problem with completion

[Sven Wischnowsky]

Andrej Borsenkow wrote:

> I have a feeling, that with new completion the complete line is refreshed
> every time. I noted that, as my display flickers sometimes quite ugly. It's
> getting worse, when logical line extends over several terminal lines ...
> Anybody else seen it?

That's not restricted to the new completion. It's caused by the way
`clearlist' (the variable that triggers clearing a list that may be
beneath the prompt) works -- it forces a redisplay of the prompt.

I tried to do this in a more sophisticated way (moving the cursor
under the prompt, clear to EOD, move cursor up), but couldn't get it
to work with the rest of the redisplay code. I'm not one of the most
knowledgeable persons with respect to the zle redisplay code, so I
have to ask: can someone come up with a better imlpementation?

Thanks for the reminder.

Bye
 Sven


--
Sven Wischnowsky                         wischnow@informatik.hu-berlin.de

Minor refresh problem with completion

[Andrej Borsenkow]

I have a feeling, that with new completion the complete line is refreshed
every time. I noted that, as my display flickers sometimes quite ugly. It's
getting worse, when logical line extends over several terminal lines ...
Anybody else seen it?

cheers

/andrej