From: Sven Wischnowsky <wischnow@informatik.hu-berlin.de>
To: zsh-workers@sunsite.auc.dk
Subject: Re: yet another undesired 3.1.5-pws-15 change
Date: Fri, 23 Apr 1999 12:59:46 +0200 (MET DST) [thread overview]
Message-ID: <199904231059.MAA32358@beta.informatik.hu-berlin.de> (raw)
In-Reply-To: Timothy J Luoma's message of Fri, 23 Apr 1999 06:14:10 -0400
Timothy J Luoma wrote:
> 3.1.5-pws-15
>
> #cd $la[tab] gives me
>
> # cd $lapps[spacehere][cursor here]
>
> how can I get the 3.1.4 behavior back?
By applying the patch below.
> ps -- there seem to be a LOT of these types of changes in 3.1.5....
Please name them, because...
> I wish
> there were more consideration given to keeping things consistent for those
> who upgrade... changing the way things behave and making the user reconfigure
> everything is not a good thing...
...of course, we (w.r.t. the completion code: I) tried to keep the old
behavior, but there were a lot of changes in the code needed for the
new features (and there are many of them) and so I didn't manage to do
so in some cases.
Again: if you find things that behave differently now, and if the
change isn't a good thing, please let us know and I'll attempt to fix
it.
As for your other message: I need some more help here since I can't
reproduce it. Can you complete the names that don't appear in the
list? By giving an unambiguous prefix? Only with menucompletion? This
is NextStep (right?): did you get any compiler warnings in
Zle/zle_tricky.c? (Weird question, but I have no idea how what you
described can happen...)
The patch: it's do_single() again, failing to build the expanded path
for the parameter just completed.
Bye
Sven
diff -u os/Zle/zle_tricky.c Src/Zle/zle_tricky.c
--- os/Zle/zle_tricky.c Tue Apr 13 10:32:15 1999
+++ Src/Zle/zle_tricky.c Fri Apr 23 12:45:52 1999
@@ -6970,10 +6976,20 @@
t = 1;
else {
/* Build the path name. */
- p = (char *) zhalloc(strlen(prpre) + strlen(str) +
- strlen(psuf) + 3);
- sprintf(p, "%s%s%s", (prpre && *prpre) ? prpre : "./", str, psuf);
+ if (m->ripre && !*psuf) {
+ int ne = noerrs;
+ p = (char *) zhalloc(strlen(m->ripre) + strlen(str) + 1);
+ sprintf(p, "%s%s", m->ripre, str);
+ noerrs = 1;
+ parsestr(p);
+ singsub(&p);
+ noerrs = ne;
+ } else {
+ p = (char *) zhalloc(strlen(prpre) + strlen(str) +
+ strlen(psuf) + 3);
+ sprintf(p, "%s%s%s", (prpre && *prpre) ? prpre : "./", str, psuf);
+ }
/* And do the stat. */
t = (!(sr = ztat(p, &buf, 0)) && S_ISDIR(buf.st_mode));
}
--
Sven Wischnowsky wischnow@informatik.hu-berlin.de
next reply other threads:[~1999-04-23 10:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
1999-04-23 10:59 Sven Wischnowsky [this message]
1999-04-24 3:11 ` Timothy J Luoma
1999-04-25 13:44 ` Peter Stephenson
1999-04-25 14:35 ` Geoff Wing
1999-04-25 15:22 ` PATCH: 3.1.5-pws-15: multiline prompt Geoff Wing
[not found] ` <990423234917.ZM30140@candle.brasslantern.com>
[not found] ` <199904241324.JAA23300@ocalhost>
[not found] ` <990424092703.ZM32177@candle.brasslantern.com>
[not found] ` <199904302157.RAA26524@ocalhost>
[not found] ` <990504100735.ZM28408@candle.brasslantern.com>
1999-05-11 2:40 ` success (mostly) pws 17 under NeXTStep 3.3 Timothy J Luoma
1999-05-11 8:06 ` Peter Stephenson
-- strict thread matches above, loose matches on Subject: below --
1999-04-23 10:14 yet another undesired 3.1.5-pws-15 change Timothy J Luoma
1999-04-28 18:13 ` Wayne Davison
1999-04-30 23:24 ` Timothy J Luoma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=199904231059.MAA32358@beta.informatik.hu-berlin.de \
--to=wischnow@informatik.hu-berlin.de \
--cc=zsh-workers@sunsite.auc.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).