From: Sven Wischnowsky <wischnow@informatik.hu-berlin.de>
To: zsh-workers@sunsite.auc.dk
Subject: Re: PATCH and comments Re: PATCH: autoloaded parameters
Date: Fri, 30 Apr 1999 11:09:41 +0200 (MET DST) [thread overview]
Message-ID: <199904300909.LAA22036@beta.informatik.hu-berlin.de> (raw)
In-Reply-To: "Bart Schaefer"'s message of Thu, 29 Apr 1999 23:23:15 -0700
Bart Schaefer wrote:
> First comment: This new code does not link with --disable-dynamic.
Grrr, Sven, Wake Up.
> Patch below.
Thanks.
> On Apr 28, 11:51am, Sven Wischnowsky wrote:
> } Subject: PATCH: autoloaded parameters
> }
> } Autoloaded parameters are stored in it like normal parameters, but
> } with a new flag (PM_AUTOLOAD). Then I changed the getnode-functions of
> } paramtab to use a new function getparamnode() which calls
> } gethashnode2() and then checks if the Param returned has the
> } PM_AUTOLOAD flag set. If it has, the module is loaded.
> [...]
> } - To avoid having a `local' with the name of a parameter that will
> } be autoloaded trigger the loading of the module, I had to change
> } calls like `paramtab->getnode()' to `gethashnode2(paramtab,...)'
>
> Hrm. Is this really the only place to hook this in? Seems like doing
> it there means that you load the module as soon as anybody references
> the parameter, even if all that's done is to test whether it's set.
>
> Heck, it means the module gets loaded if "unset ..." is used on the
> parameter!
No, it doesn't. Because I've also hooked it into createparam().
But, yes, parameters are autoloaded when tested for settedness (err,
well, you know what I mean). Somehow I liked that... To change this,
we would, as you know, have to fiddle some more in paramsubst().
> And what happens in createparamtable() if there's an environment variable
> with the same name as one of the autoloaded parameters? Or is it not
> possible to have an autoloaded parameter at that point?
Well, setupvals()->createparamtable() is called before
init_bltinmods() registers autoloaded modules. So, currently there
shouldn't be a problem.
> } - For now, I made `typeset' without arguments not print the
> } autoloaded parameters because we have virtually no information
> } about them as long as the module is not loaded. But since `which'
> } reports builtins even when their module isn't loaded yet, we might
> } want to change this. (What exactly should it print then?)
>
> It should probably show the type as "undefined" the same as is done for
> autoloaded functions.
Hm, yes, sounds reasonable.
Bye
Sven
--- os/params.c Thu Apr 29 11:57:27 1999
+++ Src/params.c Fri Apr 30 11:07:42 1999
@@ -2717,11 +2717,13 @@
Param p = (Param) hn;
char *t, **u;
- if (p->flags & (PM_UNSET | PM_AUTOLOAD))
+ if (p->flags & PM_UNSET)
return;
/* Print the attributes of the parameter */
if (printflags & PRINT_TYPE) {
+ if (p->flags & PM_AUTOLOAD)
+ printf("undefined ");
if (p->flags & PM_INTEGER)
printf("integer ");
else if (p->flags & PM_ARRAY)
@@ -2755,6 +2757,11 @@
}
quotedzputs(p->nam, stdout);
+
+ if (p->flags & PM_AUTOLOAD) {
+ putchar('\n');
+ return;
+ }
if (printflags & PRINT_KV_PAIR)
putchar(' ');
else
--
Sven Wischnowsky wischnow@informatik.hu-berlin.de
next reply other threads:[~1999-04-30 9:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
1999-04-30 9:09 Sven Wischnowsky [this message]
-- strict thread matches above, loose matches on Subject: below --
1999-04-28 9:51 Sven Wischnowsky
1999-04-30 6:23 ` PATCH and comments " Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=199904300909.LAA22036@beta.informatik.hu-berlin.de \
--to=wischnow@informatik.hu-berlin.de \
--cc=zsh-workers@sunsite.auc.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).