pws-20 bug >> completion makes partial line vanish

pws-20 bug >> completion makes partial line vanish

[Timothy J Luoma]

OK I didn't know how to make a good Subject: line for this, but here's the  
scenario which I think it new to pws-20:


I'm in the "Src" directory after a successful 'make' of pws-20


# mv zs[tab]

gives me

# mv zsh
zsh*                    zsh.export              zsh.mdhi                zshxmods.h 
zsh-3.1.5-pws-20*       zsh.h                   zsh.mdhs
zsh-3.1.5-pws-20-NI*    zsh.mdd                 zsh.test*
zsh-3.1.5-pws-20-m68k*  zsh.mdh                 zshpaths.h

# mv zsh[tab] gives me
# mv zsh-3.1.5-pws-20
zsh*                    zsh.export              zsh.mdhi                zshxmods.h 
zsh-3.1.5-pws-20*       zsh.h                   zsh.mdhs
zsh-3.1.5-pws-20-NI*    zsh.mdd                 zsh.test*
zsh-3.1.5-pws-20-m68k*  zsh.mdh                 zshpaths.h

(now I use my UP ARROW to get a history replacement and get this as a result)

#mv zsh             -NI /usr/bin

(notice the big empty space?)

with the cursor over the '-' of '-NI'

control a & control e (beginning of line/end of line) and I get the proper

#mv zsh-3.1.5-pws-20-NI /usr/bin


Anyone know what this is all about?

TjL

Re: pws-20 bug >> completion makes partial line vanish

[Timothy J Luoma]

Replying to message of Tue, 1 Jun 1999 10:37:48 +0200 (MET DST)
	from Sven Wischnowsky <wischnow@informatik.hu-berlin.de>
	regarding ``Re: pws-20 bug >> completion makes partial line vanish''
	
> At that place it really should use the old display-buffer contents, so
> the patch just temporarily makes it use that. Not a very nice patch, I
> agree.

But it did work

Thanks
TjL

Re: pws-20 bug >> completion makes partial line vanish

[Sven Wischnowsky]

Timothy J Luoma wrote:

> # mv zsh[tab] gives me
> # mv zsh-3.1.5-pws-20
> zsh*                    zsh.export              zsh.mdhi                zshxmods.h 
> zsh-3.1.5-pws-20*       zsh.h                   zsh.mdhs
> zsh-3.1.5-pws-20-NI*    zsh.mdd                 zsh.test*
> zsh-3.1.5-pws-20-m68k*  zsh.mdh                 zshpaths.h
> 
> (now I use my UP ARROW to get a history replacement and get this as a result)
> 
> #mv zsh             -NI /usr/bin
> 
> (notice the big empty space?)

That comes from trying to clear the list on terminals for which zsh
thinks that they can't do TCMULTRIGHT (zsh thinks my xterm can't do
that, hm...).
In the excerpt below, the second moveto() has to move over the old
line contents. But since it thinks, the terminal is not able to do
TCMULTRIGHT, it starts inserting stuff from the new display buffer
(nbuf), which is not yet set up. And because of that, it starts
inserting spaces.
At that place it really should use the old display-buffer contents, so 
the patch just temporarily makes it use that. Not a very nice patch, I 
agree.

Bart, I haven't tried this with pre-3, but I think it may be important 
to have there, too (unless the display code in 3.1.5 has changed more
than I think it has).

Bye
 Sven

--- os/Zle/zle_refresh.c	Tue May 25 09:15:36 1999
+++ Src/Zle/zle_refresh.c	Tue Jun  1 10:28:49 1999
@@ -268,10 +268,13 @@
     if (clearlist && listshown) {
 	if (tccan(TCCLEAREOD)) {
 	    int ovln = vln, ovcs = vcs;
+	    char *nb = nbuf[vln];
 
+	    nbuf[vln] = obuf[vln];
 	    moveto(nlnct, 0);
 	    tcout(TCCLEAREOD);
 	    moveto(ovln, ovcs);
+	    nbuf[vln] = nb;
 	} else {
 	    invalidatelist();
 	    moveto(0, 0);

--
Sven Wischnowsky                         wischnow@informatik.hu-berlin.de