Re: PATCH: Omissions (Re: pws-23)

Re: PATCH: Omissions (Re: pws-23)

[Sven Wischnowsky]

Bart Schaefer wrote:

> The first hunk of Sven's 6414 is missing.  This may be intentional, because
> it fixes one bug by introducing another less-likely one, but the ChangeLog
> says it should be there.
> 
> Index: Src/Zle/zle_tricky.c
> ===================================================================
> @@ -735,7 +735,7 @@
>  		*b != '=' && *b != Equals &&
>  		*b != '~' && *b != Tilde)
>  		break;
> -	if (*b == '#' || *b == Pound || *b == '+')
> +	if (*b == '#' || *b == Pound || *b == '+' || *b == ' ')
>  	    b++;
>  
>  	e = b;

I took that out in 6492.

> The documentation in compsys.yo from Sven's 6686 is also missing.

But that should be added.


Bye
 Sven


--
Sven Wischnowsky                         wischnow@informatik.hu-berlin.de

PATCH: Omissions (Re: pws-23)

[Bart Schaefer]

The first hunk of Sven's 6414 is missing.  This may be intentional, because
it fixes one bug by introducing another less-likely one, but the ChangeLog
says it should be there.

Index: Src/Zle/zle_tricky.c
===================================================================
@@ -735,7 +735,7 @@
 		*b != '=' && *b != Equals &&
 		*b != '~' && *b != Tilde)
 		break;
-	if (*b == '#' || *b == Pound || *b == '+')
+	if (*b == '#' || *b == Pound || *b == '+' || *b == ' ')
 	    b++;
 
 	e = b;

The documentation in compsys.yo from Sven's 6686 is also missing.

Index: Doc/Zsh/compsys.yo
===================================================================
@@ -474,6 +474,12 @@
 `tt(*)' will be inserted. If tt(match_original) has any other non-empty
 string as its value, this completer will first try to generate matches
 without, then with a `tt(*)' inserted at the cursor position.
+
+The generated matches will be offered in a menucompletion unless the
+tt(match_insert) configuration key is set to a string starting with
+`tt(unambig)'. In this case menucompletion will only be started if no
+unambiguous string could be generated that is at least as long as the
+original string.
 )
 item(tt(_expand))(
 This completer function does not really do completion, but instead
@@ -707,10 +713,13 @@
 `tt(-S)', `tt(-q)', `tt(-r)', and `tt(-R)' options from the
 tt(compadd) builtin.
 
-Finally, the tt(_path_files) function supports one configuration key:
-tt(path_expand). If this is set to any non-empty string, the partially
+Finally, the tt(_path_files) function supports two configuration keys.
+If tt(path_expand) is set to any non-empty string, the partially
 typed path from the line will be expanded as far as possible even if
-trailing pathname components can not be completed.
+trailing pathname components can not be completed. And if
+tt(path_cursor) is set to a non-empty string, the cursor will be left
+after the first ambiguous pathname component even when menucompletion
+is used.
 )
 item(tt(_parameters))(
 This should be used to complete parameter names if you need some of the

-- 
Bart Schaefer                                 Brass Lantern Enterprises
http://www.well.com/user/barts              http://www.brasslantern.com