From: Sven Wischnowsky <wischnow@informatik.hu-berlin.de>
To: zsh-workers@sunsite.auc.dk
Subject: Re: Small problem with suspend-a-loop patch (6707)
Date: Mon, 21 Jun 1999 13:20:10 +0200 (MET DST) [thread overview]
Message-ID: <199906211120.NAA22572@beta.informatik.hu-berlin.de> (raw)
In-Reply-To: "Bart Schaefer"'s message of Sat, 19 Jun 1999 05:35:03 +0000
Bart Schaefer wrote:
> The first time a loop is suspended and then brought back into the foreground,
> the job status is reported incorrectly; every time thereafter it's correct.
Oh. there was this explicit test to avoid setting the status of the
last process of a super-job to SP_RUNNING (the last process is the
shell forked for the tail of a pipeline).
I don't remember why we had this test, so I only #if'ed it out for
now. Stopping/continuing loops with and without pipes seems to
reported the status correclty with that, but please look out for wrong
reports everyone.
Bye
Sven
--- os/jobs.c Mon Jun 21 12:49:40 1999
+++ Src/jobs.c Mon Jun 21 13:13:34 1999
@@ -92,8 +92,12 @@
jn->stat &= ~STAT_STOPPED;
for (pn = jn->procs; pn; pn = pn->next)
+#if 0
if (WIFSTOPPED(pn->status) &&
(!(jn->stat & STAT_SUPERJOB) || pn->next))
+ pn->status = SP_RUNNING;
+#endif
+ if (WIFSTOPPED(pn->status))
pn->status = SP_RUNNING;
if (jn->stat & STAT_SUPERJOB)
--
Sven Wischnowsky wischnow@informatik.hu-berlin.de
next reply other threads:[~1999-06-21 11:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
1999-06-21 11:20 Sven Wischnowsky [this message]
1999-06-21 15:47 ` Peter Stephenson
-- strict thread matches above, loose matches on Subject: below --
1999-06-19 5:35 Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=199906211120.NAA22572@beta.informatik.hu-berlin.de \
--to=wischnow@informatik.hu-berlin.de \
--cc=zsh-workers@sunsite.auc.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).