From: Sven Wischnowsky <wischnow@informatik.hu-berlin.de>
To: zsh-workers@sunsite.auc.dk
Subject: Re: 3.0.6-pre-5 problem
Date: Fri, 25 Jun 1999 11:38:32 +0200 (MET DST) [thread overview]
Message-ID: <199906250938.LAA02038@beta.informatik.hu-berlin.de> (raw)
In-Reply-To: "Bart Schaefer"'s message of Fri, 25 Jun 1999 09:23:39 +0000
Bart Schaefer wrote:
> On Jun 25, 9:17am, Bart Schaefer wrote:
> } Subject: Re: 3.0.6-pre-5 problem
> }
> } [...] I think zsh
> } may have sent a STOP signal to the xterm that is its parent.
>
> Yup, I can confirm this:
>
> zagzig% Src/zsh -f
> zagzig% echo $SHLVL
> 4
> zagzig% Src/zsh -f
> zagzig% echo $SHLVL
> 5
> zagzig% mutt () {
> function> command mutt "$@"
> function> echotc rs
> function> }
> zagzig% mutt
> zsh: suspended (signal) Src/zsh -f
> zagzig% echo $SHLVL
> 4
>
> Zsh has just stopped its parent. Naughty zsh.
Err, itself, right?
That was a hint... (I still wonder why I can't reproduce it, though).
I hope this fixes it. It's the only place where a parent shell sends a
SIGSTOP and, yes, it's good to have that extra test there -- it means
roughly that we don't need to suspend the beginning of a pipeline if
there is no such beginning -- exactly what happens when suspending a
function.
Bye
Sven
--- os/exec.c Fri Jun 25 10:06:02 1999
+++ Src/exec.c Fri Jun 25 11:32:57 1999
@@ -966,7 +966,7 @@
close(synch[1]);
read(synch[0], &dummy, 1);
close(synch[0]);
- /* If this job has finished, we turn this into a
+ /* If this job has finished, we leave it as a
* normal (non-super-) job. */
if (!(jn->stat & STAT_DONE)) {
jobtab[list_pipe_job].other = newjob;
@@ -974,7 +974,7 @@
jn->stat |= STAT_SUBJOB | STAT_NOPRINT;
jn->other = pid;
}
- if (list_pipe || last1)
+ if ((list_pipe || last1) && jobtab[list_pipe_job].procs)
killpg(jobtab[list_pipe_job].gleader, SIGSTOP);
break;
}
--
Sven Wischnowsky wischnow@informatik.hu-berlin.de
next reply other threads:[~1999-06-25 9:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
1999-06-25 9:38 Sven Wischnowsky [this message]
1999-06-25 10:10 ` Bart Schaefer
-- strict thread matches above, loose matches on Subject: below --
1999-06-25 12:52 Sven Wischnowsky
1999-06-25 15:56 ` Peter Stephenson
1999-06-25 16:29 ` Bart Schaefer
1999-06-25 17:14 ` Bart Schaefer
1999-06-25 9:19 Sven Wischnowsky
1999-06-25 6:22 Sven Wischnowsky
1999-06-25 9:03 ` Bart Schaefer
1999-06-25 9:17 ` Bart Schaefer
1999-06-25 9:23 ` Bart Schaefer
1999-06-24 15:05 Jos Backus
1999-06-24 15:26 ` Jos Backus
1999-06-24 18:54 ` Jos Backus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=199906250938.LAA02038@beta.informatik.hu-berlin.de \
--to=wischnow@informatik.hu-berlin.de \
--cc=zsh-workers@sunsite.auc.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).