From: Sven Wischnowsky <wischnow@informatik.hu-berlin.de>
To: zsh-workers@sunsite.auc.dk
Subject: Re: BUG: zsh-3.1.5-pws-24: time is dead
Date: Fri, 2 Jul 1999 08:32:35 +0200 (MET DST) [thread overview]
Message-ID: <199907020632.IAA14650@beta.informatik.hu-berlin.de> (raw)
In-Reply-To: mason@primenet.com.au's message of 2 Jul 1999 02:05:17 GMT
mason@primenet.com.au wrote:
> Sven Wischnowsky <wischnow@informatik.hu-berlin.de> typed:
> :mason@primenet.com.au wrote:
> :> % time =echo foobar
> :> foobar
> :This patch seems to work, but since I don't know why it worked before,
> :I'm not really happy with it.
>
> I'm not happy with it either. It works, but it looks like a hack.
> Comment from zsh.h:
> #define STAT_NOPRINT (1<<5) /* job was killed internally, */
> /* we don't want to show that */
> Is STAT_NOPRINT being used for other purposes now? Are we getting the wrong
> status for jobs while trying to work around all these other programs which
> want certain pgrp/session requirements?
Yes. I knew about this, I only couldn't find the place where NOPRINT
was set where it hadn't been set before immediatly. But now I found it.
This goes on top of 6936, in the hope that this is more convenient for
you.
Bye
Sven
diff -u os/exec.c Src/exec.c
--- os/exec.c Wed Jun 30 11:56:49 1999
+++ Src/exec.c Fri Jul 2 08:30:18 1999
@@ -890,7 +890,7 @@
lastwj = thisjob = newjob;
- if (list_pipe || pline_level)
+ if (list_pipe || (pline_level && !(how & Z_TIMED)))
jn->stat |= STAT_NOPRINT;
if (nowait) {
diff -u os/jobs.c Src/jobs.c
--- os/jobs.c Thu Jul 1 08:50:47 1999
+++ Src/jobs.c Fri Jul 2 08:28:42 1999
@@ -494,14 +494,9 @@
int conted = 0, lineleng = columns, skip = 0, doputnl = 0;
FILE *fout = (synch == 2) ? stdout : shout;
- if (jn->stat & STAT_NOPRINT) {
- if ((jn->stat & (STAT_TIMED | STAT_DONE)) == (STAT_TIMED | STAT_DONE) &&
- should_report_time(jn)) {
- jn->stat &= ~STAT_TIMED;
- dumptime(jn);
- }
+ if (jn->stat & STAT_NOPRINT)
return;
- }
+
if (lng < 0) {
conted = 1;
lng = 0;
--
Sven Wischnowsky wischnow@informatik.hu-berlin.de
next reply other threads:[~1999-07-02 6:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
1999-07-02 6:32 Sven Wischnowsky [this message]
1999-07-02 8:07 ` Geoff Wing
-- strict thread matches above, loose matches on Subject: below --
1999-07-01 6:39 Sven Wischnowsky
1999-07-02 2:05 ` Geoff Wing
1999-06-30 18:09 Geoff Wing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=199907020632.IAA14650@beta.informatik.hu-berlin.de \
--to=wischnow@informatik.hu-berlin.de \
--cc=zsh-workers@sunsite.auc.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).